Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix extrinsic failed event not throwing error #191

Merged
merged 5 commits into from
Jun 7, 2023
Merged

fix: fix extrinsic failed event not throwing error #191

merged 5 commits into from
Jun 7, 2023

Conversation

mpetrun5
Copy link
Collaborator

@mpetrun5 mpetrun5 commented Jun 2, 2023

Fix extrinsic failed event not throwing error.
Also, send nil signature on signing when relayer is not coordinator to cancel the signing.

Description

Related Issue Or Context

Closes: #190

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Go Test coverage is 65.7 %\ ✨ ✨ ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Go Test coverage is 65.7 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit c45f3ee into main Jun 7, 2023
@mpetrun5 mpetrun5 deleted the mpetrun5/fix-extrinsic-failed branch June 7, 2023 08:31
@MakMuftic MakMuftic mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

@P1sar P1sar P1sar approved these changes

@waymobetta waymobetta Awaiting requested review from waymobetta

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

@nmlinaric nmlinaric Awaiting requested review from nmlinaric nmlinaric is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for failed handler execution on substrate
3 participants
@mpetrun5 @P1sar @MakMuftic