Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: possible race condition #316

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix: possible race condition #316

merged 2 commits into from
Jul 10, 2024

Conversation

tcar121293
Copy link
Contributor

fix possible race condition

Description

Related Issue Or Context

Closes: https://veridise.notion.site/Possible-race-conditions-1fd783d2bdab4305bc8d1100e6952fe2

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@tcar121293
add propMutex.Lock();
c821399 
Signed-off-by: tcar <tcar121293@gmail.com>
@tcar121293
move mutex.Unlock() outside of the loop;
0843d6f 
Signed-off-by: tcar <tcar121293@gmail.com>
@tcar121293 tcar121293 changed the title chore: fix possible race condition fix: possible race condition Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.0 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit b9b5341 into main Jul 10, 2024
8 checks passed
@mpetrun5 mpetrun5 deleted the tcar/fix-possible-race-conditions branch July 10, 2024 12:03
@MakMuftic MakMuftic mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmlinaric nmlinaric nmlinaric approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@MakMuftic MakMuftic Awaiting requested review from MakMuftic MakMuftic is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcar121293 @mpetrun5 @nmlinaric