Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: match configs by domainID #375

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

mpetrun5
Copy link
Collaborator

@mpetrun5 mpetrun5 commented Oct 9, 2024

Match configs by domainID to prevent errors when the shared config and relayer config are mismatched.

How it functions now:

  • relayer config is the source of truth
  • SYG_CHAINS from relayer is matched by domainID with the shared config ID
  • if the config in shared config is missing the relayer will throw an error
  • configs don't have to be ordered

Description

Related Issue Or Context

Closes: #374

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Go Test coverage is 66.9 %\ ✨ ✨ ✨

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Go Test coverage is 66.8 %\ ✨ ✨ ✨

@MakMuftic MakMuftic merged commit f695875 into main Oct 23, 2024
8 checks passed
@MakMuftic MakMuftic deleted the mpetrun5/match-config-by-domainID branch October 23, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match config per domainID
3 participants