Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable setting custom transfer gas per chain #376

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

mpetrun5
Copy link
Collaborator

To resolve problems on Arbitrum we have to enable setting custom gas per transfer per chain.
For Arbitrum we will have to set a very high gas limit to have a buffer base don network performance.

Description

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Copy link
Contributor

Go Test coverage is 66.9 %\ ✨ ✨ ✨

@MakMuftic
Copy link
Contributor

@mpetrun5 we can test this with Arbitrum on testnet

@MakMuftic MakMuftic added the QA label Oct 23, 2024
Copy link
Contributor

Go Test coverage is 66.8 %\ ✨ ✨ ✨

@MakMuftic MakMuftic merged commit 0b38483 into main Oct 23, 2024
8 checks passed
@MakMuftic MakMuftic deleted the mpetrun5/default-to-estimategas branch October 23, 2024 09:51
@LyonSsS
Copy link

LyonSsS commented Oct 28, 2024

https://sepolia.arbiscan.io/address/0xfb2530fb3f5801ad35ccd6fda29715d9330b7f9f tests done on all the executeporposals from 28_10_2024 - and now is passed on testnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants