Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with ivy-hydra #71

Open
kangjianbin opened this issue Sep 24, 2016 · 1 comment
Open

Doesn't work with ivy-hydra #71

kangjianbin opened this issue Sep 24, 2016 · 1 comment
Labels

Comments

@kangjianbin
Copy link

Reproduce:

  1. Enter ivy (SPC b b)
  2. Enter hydra-ivy (C-o)
  3. Press escape sequence to exit minibuffer

I found that ivy exited but hydra-ivy didn't exit.
I changed =evil-escape--escape-normal-state= to

(defun evil-escape--escape-normal-state ()
  "Return the function to escape from normal state."
  (cond
   ((and (fboundp 'helm-alive-p) (helm-alive-p)) 'helm-keyboard-quit)
   ((eq 'ibuffer-mode major-mode) 'ibuffer-quit)
   ((eq 'image-mode major-mode) 'quit-window)
   ((evil-escape--is-magit-buffer) 'evil-escape--escape-with-q)
   ((bound-and-true-p isearch-mode) 'isearch-abort)
   ((window-minibuffer-p) (kbd "C-g"))
   (t (lookup-key evil-normal-state-map [escape]))))

And it works. The reason is that hydra-ivy also binds "C-g" to exit.

@syl20bnr
Copy link
Owner

Are you still using evil-escape ? If yes and this change has been stable for you, I would be happy to merge this change.

@syl20bnr syl20bnr added the bug label Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants