`helm-project-smart-do-search` breaks and errors, doesn't jump to correct line #15437

Davidj361 · 2022-03-30T17:49:30Z

Description

Doing spacemacs/helm-project-smart-do-search and searching for 'supp' in this code gives an error of:
Search failed: there is an unmatched expression somewhere or we are at the beginning/end of file. [4 times]

void foobar(Foo1 * foo1, Bar1 * bar2)
{
    if (((foo->supp)&&(foo1->sec || d.s ||
        (foo->offset &&
            (abs(bar2->sec) >=
          foo->offset)))) || ((!foo->supp) && (foo1->sec))){
}

Reproduction guide 🪲

Start Emacs
create directory for files below
put code from above into test.c
create a .projectile in the same directory
SPC / OR SPC s p
Search for 'supp'
You will get an error and the jump won't take you to the right line.

Observed behaviour: 👀 💔

2022-03-30.13-52-31.mp4

When I jump to the entry it doesn't jump to the right line and instead jumps to the starting curly brace '{'.

Expected behaviour: ❤️ 😄

When I jump to the entry it should take me to the correct line such as line 3.

System Info 💻

OS: gnu/linux
Emacs: 27.2
Spacemacs: 0.999.0
Spacemacs branch: develop (rev. 18ad975)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: helm
Layers:

(auto-completion emacs-lisp helm helpful dap lsp markdown multiple-cursors
                 (org :variables org-startup-indented t org-indent-mode t)
                 (c-c++ :variables c-c++-backend 'lsp-clangd)
                 spell-checking syntax-checking treemacs)

System configuration features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP

Backtrace 🐾

Debugger entered--Lisp error: (scan-error "Unbalanced parentheses" 39 202)
  scan-sexps(39 1)
  forward-sexp(1)
  hs-forward-sexp((39 40 #<buffer test.c>) 1)
  hs-find-block-beginning()
  #f(compiled-function (&optional end) "Select a block and show it.\nWith prefix arg, reposition at END.  Upon completion, point is\nrepositioned and the normal hook `hs-show-hook' is run.\nSee documentation for functions `hs-hide-block' and `run-hooks'." (interactive "P") #<bytecode 0x1593c8bc1a65>)(nil)
  ad-Advice-hs-show-block(#f(compiled-function (&optional end) "Select a block and show it.\nWith prefix arg, reposition at END.  Upon completion, point is\nrepositioned and the normal hook `hs-show-hook' is run.\nSee documentation for functions `hs-hide-block' and `run-hooks'." (interactive "P") #<bytecode 0x1593c8bc1a65>))
  apply(ad-Advice-hs-show-block #f(compiled-function (&optional end) "Select a block and show it.\nWith prefix arg, reposition at END.  Upon completion, point is\nrepositioned and the normal hook `hs-show-hook' is run.\nSee documentation for functions `hs-hide-block' and `run-hooks'." (interactive "P") #<bytecode 0x1593c8bc1a65>) nil)
  hs-show-block()
  helm-goto-char(56)
  helm-ag--find-file-action("test.c:3:    if (((foo->supp)&&(foo1->sec || d.s |..." find-file nil)
  helm-ag--action-find-file("test.c:3:    if (((foo->supp)&&(foo1->sec || d.s |...")
  helm-execute-selection-action-1()
  helm-execute-selection-action()
  helm-internal(helm-source-do-ag "" nil nil nil "*helm-ag*" (keymap (3 keymap ...) (12 . helm-ag--do-ag-up-one-level) keymap (normal-state keymap "Auxiliary keymap for..." ...) (left . helm-ag--previous-file) (right . helm-ag--next-file) (24 keymap ...) (12 . helm-ag--up-one-level) (3 keymap ... ... ... ... ...) keymap (C-iso-lefttab . helm-follow-action-backward) (26 . helm-select-action) (tab . helm-execute-persistent-action) (33554440 . describe-key) (33554443 . helm-follow-action-backward) (33554442 . helm-follow-action-forward) (17 . ace-jump-helm-line) (f13 lambda nil ... ...) (f12 lambda nil ... ...) ...) nil helm-ag--helm-history)
  apply(helm-internal (helm-source-do-ag "" nil nil nil "*helm-ag*" (keymap ... ... keymap ... ... ... ... ... ... keymap ... ... ... ... ... ... ... ... ... ...) nil helm-ag--helm-history))
  helm(helm-source-do-ag "" nil nil nil "*helm-ag*" (keymap (3 keymap ...) (12 . helm-ag--do-ag-up-one-level) keymap (normal-state keymap "Auxiliary keymap for..." ...) (left . helm-ag--previous-file) (right . helm-ag--next-file) (24 keymap ...) (12 . helm-ag--up-one-level) (3 keymap ... ... ... ... ...) keymap (C-iso-lefttab . helm-follow-action-backward) (26 . helm-select-action) (tab . helm-execute-persistent-action) (33554440 . describe-key) (33554443 . helm-follow-action-backward) (33554442 . helm-follow-action-forward) (17 . ace-jump-helm-line) (f13 lambda nil ... ...) (f12 lambda nil ... ...) ...) nil helm-ag--helm-history)
  apply(helm (helm-source-do-ag "" nil nil nil "*helm-ag*" (keymap ... ... keymap ... ... ... ... ... ... keymap ... ... ... ... ... ... ... ... ... ...) nil helm-ag--helm-history))
  helm(:sources helm-source-do-ag :buffer "*helm-ag*" :keymap (keymap (3 keymap ...) (12 . helm-ag--do-ag-up-one-level) keymap (normal-state keymap "Auxiliary keymap for..." ...) (left . helm-ag--previous-file) (right . helm-ag--next-file) (24 keymap ...) (12 . helm-ag--up-one-level) (3 keymap ... ... ... ... ...) keymap (C-iso-lefttab . helm-follow-action-backward) (26 . helm-select-action) (tab . helm-execute-persistent-action) (33554440 . describe-key) (33554443 . helm-follow-action-backward) (33554442 . helm-follow-action-forward) (17 . ace-jump-helm-line) (f13 lambda nil ... ...) (f12 lambda nil ... ...) ...) :input "" :history helm-ag--helm-history)
  helm-do-ag--helm(nil nil)
  helm-do-ag("/home/dj/tmp/test/")
  (let* ((root-helm-ag-base-command "rg --smart-case --no-heading --color=never --line-...") (helm-ag-base-command (if spacemacs-helm-rg-max-column-number (concat root-helm-ag-base-command " --max-columns=" (number-to-string spacemacs-helm-rg-max-column-number)) root-helm-ag-base-command))) (helm-do-ag dir))
  spacemacs/helm-files-do-rg("/home/dj/tmp/test/")
  (if dir (spacemacs/helm-files-do-rg dir) (message "error: Not in a project."))
  (let ((dir (projectile-project-root))) (if dir (spacemacs/helm-files-do-rg dir) (message "error: Not in a project.")))
  spacemacs/helm-project-do-rg()
  funcall-interactively(spacemacs/helm-project-do-rg)
  call-interactively(spacemacs/helm-project-do-rg)
  (let ((projectile-require-project-root nil)) (call-interactively (spacemacs//helm-do-search-find-tool "helm-project-do" dotspacemacs-search-tools default-inputp)))
  spacemacs/helm-project-smart-do-search()
  funcall-interactively(spacemacs/helm-project-smart-do-search)
  call-interactively(spacemacs/helm-project-smart-do-search nil nil)
  command-execute(spacemacs/helm-project-smart-do-search)

The text was updated successfully, but these errors were encountered:

smile13241324 · 2022-03-31T15:41:32Z

The issue comes from hs-minor-mode which is used by helm internally which seems to have an issue with the open curly bracket.

The build in version of this package is used in spacemacs-evil therefore its active. Please open a bug report upstream.

Edit:
As a fast workaround you can disable this mode, then helm will not use it and the error should be gone.

Davidj361 · 2022-03-31T17:41:43Z

Please open a bug report upstream.

What do you mean? Not sure where that is.

lebensterben · 2022-03-31T17:58:09Z

@Davidj361 helm

Davidj361 · 2022-03-31T18:24:01Z

Not sure how I can test this in a minimal configuration. Running emacs-helm.sh doesn't show the command and complains about helm-core missing.
https://github.com/emacs-helm/helm

Davidj361 · 2022-03-31T19:08:40Z

I've tried setting up helm from scratch in emacs via HOME=/tmp/emacs emacs with an .emacs file below

(setq-default indent-tabs-mode nil)

(require 'package)

(setq package-archives
      '(
        ("gnu" . "https://elpa.gnu.org/packages/")
        ;; ("melpa" . "https://melpa.org/packages/")
        ("nongnu" . "https://elpa.nongnu.org/nongnu/")
        ))

(let ((my-pkgs '(helm)))
  (when (seq-remove 'package-installed-p my-pkgs)
    (package-refresh-contents)
    (mapc (lambda (pkg) (package-install pkg t)) my-pkgs)))

But M-x doesn't show helm-project-smart-do-search as a command in helm. I'm not sure if I can bug report this on the upstream helm as helm-project-smart-do-search isn't a command there.

lebensterben · 2022-03-31T20:02:56Z

I will investigate.

As for now, try to use ivy or compleseus as replacement for helm.

Davidj361 · 2022-03-31T20:27:08Z

Made an issue on helm-ag

emacsorphanage/helm-ag#389

thanhvg · 2022-04-01T20:08:35Z

It's not a helm problem, in Spacemacs, turn off volatile-highlights-mode (spc thv) then your problem will be gone. volatile-highlights is really old and shouldn't be on by default. It adds a bunch of advice functions including the one that screws up hs-show-block.

If you want some fancy highlight use nav-flash layer and set vim-style-visual-feedback t in your dot file.

   dotspacemacs-editing-style '(vim :variables
                                    vim-style-visual-feedback t
                                    vim-style-remap-Y-to-y$ t
                                    vim-style-retain-visual-state-on-shift t
                                    vim-style-visual-line-move-text nil
                                    vim-style-ex-substitute-global nil)

lebensterben · 2022-04-01T20:39:21Z

good point. a replacement for vhs should be used.

Davidj361 · 2022-04-05T13:14:25Z

It's not a helm problem, in Spacemacs, turn off volatile-highlights-mode (spc thv) then your problem will be gone. volatile-highlights is really old and shouldn't be on by default. It adds a bunch of advice functions including the one that screws up hs-show-block.

@thanhvg @lebensterben

volatile-highlights-mode is not the problem afaik

When I turn off volatile-highlights-mode I still have the issue of the search result taking me to the wrong line, see my vid.

2022-04-05.09-10-45.mp4

I can replicate the same problem with bare minimal emacs with just the helm and helm-ag packages.

emacsorphanage/helm-ag#389

2022-03-31.16-23-44.mp4

thanhvg · 2022-04-05T16:33:00Z

@Davidj361 oops my bad, thanks for trying.

github-actions · 2023-04-05T16:39:14Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

Davidj361 changed the title ~~helm-project-smart-do-search breaks and errors, doesn't jump to correct line~~ helm-project-smart-do-search breaks and errors, doesn't jump to correct line Mar 30, 2022

lebensterben added - Bug tracker - Helm Help wanted labels Mar 30, 2022

smile13241324 added Should report upstream and removed Help wanted labels Mar 31, 2022

Davidj361 mentioned this issue Mar 31, 2022

helm-do-ag breaks in hs-minor-mode on this specific source file emacsorphanage/helm-ag#389

Open

lebensterben mentioned this issue Apr 1, 2022

tracking issue: replace volatile-highlight by evil-goggles #15441

Closed

github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Apr 5, 2023

github-actions bot closed this as completed Jul 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`helm-project-smart-do-search` breaks and errors, doesn't jump to correct line #15437

`helm-project-smart-do-search` breaks and errors, doesn't jump to correct line #15437

Davidj361 commented Mar 30, 2022 •

edited

Loading

smile13241324 commented Mar 31, 2022 •

edited

Loading

Davidj361 commented Mar 31, 2022

lebensterben commented Mar 31, 2022

Davidj361 commented Mar 31, 2022 •

edited

Loading

Davidj361 commented Mar 31, 2022 •

edited

Loading

lebensterben commented Mar 31, 2022 •

edited

Loading

Davidj361 commented Mar 31, 2022 •

edited

Loading

thanhvg commented Apr 1, 2022

lebensterben commented Apr 1, 2022

Davidj361 commented Apr 5, 2022

thanhvg commented Apr 5, 2022

github-actions bot commented Apr 5, 2023

helm-project-smart-do-search breaks and errors, doesn't jump to correct line #15437

helm-project-smart-do-search breaks and errors, doesn't jump to correct line #15437

Comments

Davidj361 commented Mar 30, 2022 • edited Loading

Description

Reproduction guide 🪲

System Info 💻

Backtrace 🐾

smile13241324 commented Mar 31, 2022 • edited Loading

Davidj361 commented Mar 31, 2022

lebensterben commented Mar 31, 2022

Davidj361 commented Mar 31, 2022 • edited Loading

Davidj361 commented Mar 31, 2022 • edited Loading

lebensterben commented Mar 31, 2022 • edited Loading

Davidj361 commented Mar 31, 2022 • edited Loading

thanhvg commented Apr 1, 2022

lebensterben commented Apr 1, 2022

Davidj361 commented Apr 5, 2022

thanhvg commented Apr 5, 2022

github-actions bot commented Apr 5, 2023

`helm-project-smart-do-search` breaks and errors, doesn't jump to correct line #15437

`helm-project-smart-do-search` breaks and errors, doesn't jump to correct line #15437

Davidj361 commented Mar 30, 2022 •

edited

Loading

smile13241324 commented Mar 31, 2022 •

edited

Loading

Davidj361 commented Mar 31, 2022 •

edited

Loading

Davidj361 commented Mar 31, 2022 •

edited

Loading

lebensterben commented Mar 31, 2022 •

edited

Loading

Davidj361 commented Mar 31, 2022 •

edited

Loading