Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support to set themes. #163

Closed
CestDiego opened this issue Nov 27, 2014 · 5 comments
Closed

Add better support to set themes. #163

CestDiego opened this issue Nov 27, 2014 · 5 comments
Labels

Comments

@CestDiego
Copy link
Contributor

Loading another theme in the dotemacs/init function is not enough
http://i.imgur.com/6iijztH.jpg

Somehow the colorschemes defined in solarized-light are not redefined by zenburn, so maybe a way to tell spacemacs to load zenburn the first time instead of solarized-light? That could solve it

@syl20bnr
Copy link
Owner

Did you try to disable the current theme first in dotspacemacs/config ?

(disable-theme 'solarized-light)
(load-theme 'monokai t)

@syl20bnr
Copy link
Owner

Ok same things.

So I'm divised on this issue: the right fix is to support term faces in monokai.

@syl20bnr
Copy link
Owner

Seems that monokai and zenburn miss this face (taken from solarized):

     `(term ((t ( :background ,base03 :foreground ,base0))))

@syl20bnr
Copy link
Owner

Or the other way around, solarized misses:

   `(term-default-fg-color
     ((,class (:inherit term-color-white))
      (,terminal-class (:inherit term-color-white))))

   `(term-default-bg-color
     ((,class (:inherit term-color-black))
      (,terminal-class (:inherit term-color-black))))

@syl20bnr
Copy link
Owner

I will try to fix it in solarized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants