Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some text manipulation commands broken (on dev) #1745

Closed
stormpat opened this issue May 27, 2015 · 11 comments
Closed

Some text manipulation commands broken (on dev) #1745

stormpat opened this issue May 27, 2015 · 11 comments

Comments

@stormpat
Copy link
Contributor

Moving lines up/down dont work with the commands, SPC x m j and SPC x m k

@sooheon
Copy link

sooheon commented Jun 13, 2015

On dev these key binds have been moved to spc x K and spc x J, with micro-states. Can go ahead and close.

@tko
Copy link
Contributor

tko commented Jun 14, 2015

Hmm, guide-key for SPC x doesn't mention either of the keys though they do work if you happen to know to press them. On the other hand guide-key mentions SPC x m but there's nothing there.

It looks like javascript layer is defining SPC x m j and SPC x m k keys still, though.

@tko
Copy link
Contributor

tko commented Jun 23, 2015

Regarding guide-key it seem spacemacs/init-move-text and/or spacemacs|define-micro-state isn't working properly with multiple :evil-key-leader entries. That is

:evil-key-leader "xJ" "xK"

hides both keys from the SPC x guide key menu. If you only give one or the other it gets documented similar to [J] spacemacs/move-text-micro-state which is somewhat suboptimal especially if it worked for both keys.

@CestDiego
Copy link
Contributor

that is an issue from spacemacs|define-micro-state. Also regarding the javascript issue defining SPC x m j and SPC x m k it's due to these lines https://github.com/syl20bnr/spacemacs/blob/develop/layers/+lang/javascript/packages.el#L168-L169

@CestDiego
Copy link
Contributor

I would also like to point that moving regions with this command doesn't work with evil. If one does the marking with Emacs it works but if one selects stuff with evil it breaks: here is a gif
alt

@Immortalin
Copy link
Contributor

@CestDiego how do you get the fancy symbols for elisp mode?

@CestDiego
Copy link
Contributor

@Immortalin just put (global-prettify-symbols-mode) somewhere in dotspacemacs/user-config

@aaronjensen
Copy link
Contributor

I would also like to point that moving regions with this command doesn't work with evil. If one does the marking with Emacs it works but if one selects stuff with evil it breaks: here is a gif

Just found this one, it seems like there are two issues here. Should we split this out into two issues?

@aaronjensen
Copy link
Contributor

I opened another issue for the move-text-down issue #5365

@aaronjensen
Copy link
Contributor

By the way, this original issue is fixed in develop (at least, maybe master) @StreakyCobra

@d12frosted
Copy link
Contributor

Fixed with released of Spacemacs v0.200. Let us know if you still have any problems with this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants