-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion: C-k not working consistently #2974
Comments
This works pretty fine with me in hybrid state. (evil-define-key 'hybrid company-active-map (kbd "C-j") 'company-select-next)
(evil-define-key 'hybrid company-active-map (kbd "C-k") 'company-select-previous) |
@nixmaniack With |
@StreakyCobra I have |
Ok, so it may be a clue about the bug :-) |
Updating this ticket with what I've learned on #5817:
|
@al3xandru thanks for workaround. |
Fixed with released of Spacemacs v0.200. Let us know if you still have any problems with this issue. |
Still happens to me. |
@d12frosted Reopen this issue plz. |
Seconding @cmlaverdiere, still happens to me. Even after the fix suggested by @al3xandru after waiting about a second without making a choice (although I can navigate upwards when there's no wait). Edit: It starts to fail when the documentation popup shows, which takes a little while (about a second, which I described above). Also, spacemacs often crashes after inserting |
@eullerborges @cmlaverdiere @abcdw Workaround mentioned here works for me: company-mode/company-quickhelp#63 (comment) (add-hook
'company-completion-started-hook
(lambda (&rest ignore)
(when evil-mode
(when (evil-insert-state-p)
(define-key evil-insert-state-map (kbd "C-k") nil))))) |
@malchmih Works like a charm. Thanks a lot. |
See this link on how to debug segmentation faults: |
If somebody opens a PR with it then we can merge it. We have more active maintaiers now so it should not take long. |
Merged the fix from duianto on develop just now. @cpaulik would you mind checking that this solves the issue for you and close it when it does? On my system it solved the issue in emacs and python mode. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid! |
C-j
andC-k
are bound to select completion candidates. But after the company quickhelp window popped upC-k
is no longer working correctly. It is only producing^K
in the buffer.Disabling
company-quickhelp
is a partial workaround but the same problem happens after pressingC-d
to get to the documentation.company-mode/company-quickhelp#17 suggested a possible solution of putting the keybindings into the
company-completion-finished/cancelled/started-hook
's but this did not work for me.The text was updated successfully, but these errors were encountered: