Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magit-blame and micro-state key display #3809

Closed
kvaneesh opened this issue Nov 14, 2015 · 6 comments
Closed

magit-blame and micro-state key display #3809

kvaneesh opened this issue Nov 14, 2015 · 6 comments

Comments

@kvaneesh
Copy link

blame a buffer using magit-blame, we show in mini-buffer micro state key binding. Press Enter to show commit information of any of the blame region. Now 'q' key binding is confusing. First 'q' press remove the micro state information, next one kill the commit buffer and the third cause magit-blame-quit.

I guess we have some bugs w.r.t to micro state key handling ?

-aneesh

@kvaneesh
Copy link
Author

kvaneesh commented Dec 6, 2015

magit-blame is mostly used in multi-buffer scenarios. That is after blaming a buffer, we mostly end up looking at commit details using key. That doesn't work nicely with micro-state. For example if i want to search the commit buffer using helm-swoop and want to type key 'b'; that doesn't work at all. May be we should disable micro-state for magit-blame until we get it working.

@strout
Copy link
Contributor

strout commented May 13, 2016

I frequently get a leftover blame mini-buffer after I've already quit the mode. Related to this? Should I open a separate issue for that?

@StreakyCobra
Copy link
Contributor

@strout Can you test this on develop first? It may be already fixed. If it doesn't work there please open a new issue following this template.

@tarsius
Copy link
Contributor

tarsius commented Aug 5, 2016

@kvaneesh @strout: Is this still an issue with https://github.com/justbur/evil-magit? In that case you should bring it up there, I think.

@d12frosted
Copy link
Contributor

@kvaneesh and @strout, ping-ping 😸 what is the status of this issue?

@kvaneesh
Copy link
Author

I don't hit this issue any more. this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants