Javascript Layer - jsbeautify editorconfig conflicts

[gregpardo]

This might be out of scope since editorconfig is not a layer anymore.

This issue is that when editorconfig is being used jsbeautify I believe editorconfig configuration should override whatever default jsbeautify indents and formatting are. Looking for input and thoughts on this. If this sounds reasonable I could probably hack it in. Thanks

[StreakyCobra]

It would be much more helpful if you can give us more informations. See this.

[gregpardo]

Description

With editorconfig installed, jsbeautify ignores formatting rules set in the '.editorconfig' file. For example if you have tabs set to 2 spaces in .editorconfig file and you press 'SPC m =', jsbeautify will ignore the rules set in the editorconfig. Indentation with with 'SPC j =' does use the correct indent rules from editorconfig.

Reproduction guide

• Add 'editorconfig' to dotspacemacs-additional-packages in .spacemacs
• Install editorconfig 'brew install editorconfig'
• Start Emacs
• Create an .editorconfig file to a project

[*.js]
indent_style = space
indent_size = 2

• Open a javascript file in that folder
• Make sure editorconfig is enabled with (editorconfig-mode t)
• Indent with 'SPC j =' (will use editorconfig rules)
• Beautify with 'SPC m =' (will ignore editorconfig rules)
• Notice they have different behavior with their rulesets

System Info

• OS: darwin
• Emacs: 24.5.1
• Spacemacs: 0.105.0
• Spacemacs branch: develop (rev. fbc6bc5)
• Distribution: spacemacs
• Layers:

(auto-completion better-defaults emacs-lisp git markdown org syntax-checking version-control osx javascript themes-megapack react)

[StreakyCobra]

I'm not used to javascript, but if I understand correctly jsbeautify is an external tool right?

Nevermind, I looked in the code, it's the web-beautify package that providing this functionality, and it's indeed using an external tool. If you want editorconfig parameters to be supported, it's a functionality you should ask upstream. As you said Spacemacs already works with the editorconfig packages and SPC j =.

[gregpardo]

Looks like someone else had the same idea

beautifier/js-beautify#551

[Delapouite]

Option support for editorconfig has been added to js-beautify: beautifier/js-beautify@9e2dcca

[d12frosted]

@Delapouite thanks for heads up! Closing this issue as fixed upstream.