Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version-control doesn't work for CVS (or any other backends besides git?) #4477

Closed
valrus opened this issue Jan 7, 2016 · 6 comments
Closed
Labels
Discussion Documentation ✏ stale marked as a stale issue/pr (usually by a bot) Version-control

Comments

@valrus
Copy link
Contributor

valrus commented Jan 7, 2016

I know, I know, CVS is old and terrible, but I'm at work and I have no choice.

The version-control layer claims it "should work with all VC backends," but to all appearances it's actually Git-centric. E.g.:

  • trying to do SPC g . C in a CVS-controlled buffer gives Wrong type argument: stringp, nil
  • SPC g . l gives Not inside a Git repository
  • the implementation of the layer looks like most of the bindings go to magit commands

I don't really expect any layers to actually support CVS in this day and age—I can make my own private layer for that—so maybe this can just be regarded as a documentation bug, but I think version-control's documentation is misleading if not outright wrong.

@TheBB
Copy link
Collaborator

TheBB commented Jan 7, 2016

The magit commands don't work outside of a git repository. The others should work in all repositories that your chosen margin program supports, so make sure you have chosen one with extended VCS support (that is, something other than the default value of git-gutter+). Whether these support CVS or not, I cannot say.

To see which commands are from magit and which are from elsewhere, check the documentation of the microstate (use ?)

@Ralesi This distinction should probably be made more clear. I also note that the VCS microstate will provide magit bindings even if the magit package is not installed, which is probably something we need to change.

@TheBB
Copy link
Collaborator

TheBB commented Jan 7, 2016

git-gutter supports git, mercurial, subversion and bazaar. diff-hl claims to be tested with all of these and that it "may" also support other backends.

In other words, you are probably out of luck for CVS support.

@TheBB TheBB removed the Git label Jan 7, 2016
@punassuming
Copy link
Contributor

Any currently supported method of conditionally adding bindings to a microstate?

@TheBB
Copy link
Collaborator

TheBB commented Jan 7, 2016

No there isn't. :-( Can of course hack it in a different way.

@syl20bnr This would be really handy.

@yifange
Copy link

yifange commented Jan 12, 2016

It would be nice to have some Perforce support too. I saw the perforce package and was hoping for it.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Documentation ✏ stale marked as a stale issue/pr (usually by a bot) Version-control
Projects
None yet
Development

No branches or pull requests

5 participants