Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projectile ag support? #5363

Closed
darkfeline opened this issue Mar 5, 2016 · 10 comments
Closed

Projectile ag support? #5363

darkfeline opened this issue Mar 5, 2016 · 10 comments
Labels
- Mailling list - Searching stale marked as a stale issue/pr (usually by a bot)

Comments

@darkfeline
Copy link
Contributor

projectile-ag depends in ag. ag isn't needed for the helm variant, but being able to open a results buffer is sometimes more useful than making repeated helm searches. So should we support projectile-ag?

(Related? #3141)

@darkfeline
Copy link
Contributor Author

Or one could do a helm-projectile-ag search and use C-x C-s to open a buffer with the results. Silly me.

@a13ph
Copy link

a13ph commented Mar 5, 2016

Shows how bad current helm documentation visibility is

@darkfeline
Copy link
Contributor Author

Actually, I think this deserves reconsideration since ivy, being a less ambitious kitchen sink than helm, doesn't have this feature.

@punchagan
Copy link

Also, given spacemacs is adding projectile-ag to the autoload commands list, users would expect it to work?

@sooheon
Copy link

sooheon commented Mar 12, 2016

@darkfeline I'm not sure what behavior you're referring to, as I haven't used projectile-ag, but is it anything like ivy-occur? I can call that on in-page search results or in project ag results, anything ivy lists it can print out to a buffer with live links.

@darkfeline
Copy link
Contributor Author

@sooheon Yes, it's like that, but Spacemacs's current ivy project search doesn't support it (SPC s p with spacemacs-ivy)

@sooheon
Copy link

sooheon commented Mar 12, 2016

@darkfeline It works for me for any ivy instance, including spc s p. The binding should be under C-o o.

@darkfeline
Copy link
Contributor Author

Okay, it does work, but it performs rather poorly. It seems like I need to wait for ivy to populate all the results first, which takes a lot of time, especially for a large project, otherwise ivy-occur gives me a buffer containing:

-*- mode:grep; default-directory: "<snip>" -*-

2 candidates:
./
./3 chars more

Running projectile-ag or ag by itself is much faster.

For comparison, running projectile-ag on my large project Spacemacs is almost instant, while SPC s p then C-o o I need to wait three seconds after SPC s p.

EDIT: to be fair, projectile-ag also takes three seconds or so to complete, but the buffer is open and displaying results instantly.

@kain88-de
Copy link

actually it would be nice if this is activated with ivy and counsel-projectile. It uses just wraps the counsel-ag command that is included in counsel.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Mailling list - Searching stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

No branches or pull requests

6 participants