-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl + n stops showing cursor (when kept pressed) #5456
Comments
fyi this is not an issue with commit 0562f05 |
Can you bisect? |
There is quite a bit going on ... I tried to change swap out the themes el file as well as the python one (where I see the issue the most) and haven't found it yet. I will try to go rev by rev if I have some time. Surprised no one else is having this issue. It's pretty unbearable. |
Don't do this. Use Roughly:
It will require you approximately 8 try (2^7 < 147 < 2^8). |
Thank you, this is super useful in general. Will give it a shot and get back. |
Here is the result: (.venv)➜ .emacs.d git:(103bd2b) ✗ git bisect good
e33a39c7356119cc7201ab16cef7478fdc5b8afa is the first bad commit
commit e33a39c7356119cc7201ab16cef7478fdc5b8afa
Author: syl20bnr <sylvain.benner@gmail.com>
Date: Wed Mar 2 09:13:09 2016 -0500
Update, simplify and add smooth scrolling toggle on `SPC t v`
:040000 040000 c42dc16861f27dcf020015865a2438891619dd3e e022ecbce700fa0f3578e567b51a32cee74c88ba M doc
:040000 040000 87c3425eff3f42acf7ce4f218221d8daf7d2ede4 3164366c9b70d25dbacb96bdb9caf95969283d86 M layers |
Link to the problematic commit: e33a39c Seems to be related to smooth scrolling. Can you try to disable it it by adding it to the |
Disabling |
@d12frosted Can you try reproducing this on stock emacs (without Spacemacs, |
Sure, I'll do it. But I think I'll do it only tomorrow :) |
Hmm I disabled smooth-scroll but still seem to have the issue: dotspacemacs-excluded-packages
'(
smooth-scroll
) I also tried to disable |
|
Slight update: disabling |
@d12frosted : Any update here? |
@StreakyCobra : Just tried on base emacs install and it works perfectly. (require 'package)
(setq package-archives '(("gnu" . "http://elpa.gnu.org/packages/")
("marmalade" . "http://marmalade-repo.org/packages/")
("melpa" . "http://melpa.org/packages/")))
(package-initialize)
(defun ensure-package-installed (&rest packages)
"Assure every package is installed, ask for installation if it’s not.
Return a list of installed packages or nil for every skipped package."
(mapcar
(lambda (package)
;; (package-installed-p 'evil)
(if (package-installed-p package)
nil
(if (y-or-n-p (format "Package %s is missing. Install it? " package))
(package-install package)
package)))
packages))
;; make sure to have downloaded archive description.
;; Or use package-archive-contents as suggested by Nicolas Dudebout
(or (file-exists-p package-user-dir)
(package-refresh-contents))
(setq jr-packages '(smooth-scrolling))
(dolist (pkg jr-packages)
(ensure-package-installed pkg))
(package-initialize)
(require 'smooth-scrolling)
(smooth-scrolling-mode 1) |
It's probably an interaction problem between several packages then. The goal is to find which ones 😃 |
Issue resolved by replacing this [in .emacs.d/layers/+distribution/spacemacs/packages.el]: (defun spacemacs/init-smooth-scrolling ()
(use-package smooth-scrolling
:init
(progn
(setq smooth-scroll-margin 5)
(spacemacs|add-toggle smooth-scrolling
:status smooth-scrolling-mode
:on (progn
(smooth-scrolling-mode)
(enable-smooth-scroll-for-function previous-line)
(enable-smooth-scroll-for-function next-line)
(enable-smooth-scroll-for-function isearch-repeat))
:off (progn
(smooth-scrolling-mode -1)
(disable-smooth-scroll-for-function previous-line)
(disable-smooth-scroll-for-function next-line)
(disable-smooth-scroll-for-function isearch-repeat))
:documentation "Smooth scrolling."
:evil-leader "tv")
(when dotspacemacs-smooth-scrolling
(spacemacs/toggle-smooth-scrolling-on))
;; add hooks here only for emacs built-in packages that are not owned
;; by a layer.
(defun spacemacs//unset-scroll-margin ()
"Set scroll-margin to zero."
(setq-local scroll-margin 0))
(spacemacs/add-to-hooks 'spacemacs//unset-scroll-margin
'(messages-buffer-mode-hook))))) with: (defun spacemacs/init-smooth-scrolling ()
(defun spacemacs//unset-scroll-margin ()
"Set scroll-margin to zero."
(setq-local scroll-margin 0))
(use-package smooth-scrolling
:if dotspacemacs-smooth-scrolling
:init (setq smooth-scroll-margin 5
scroll-conservatively 101
scroll-preserve-screen-position t
auto-window-vscroll nil)
:config
(progn
(setq scroll-margin 5)
;; add hooks here only for emacs built-in packages
(spacemacs/add-to-hooks 'spacemacs//unset-scroll-margin
'(messages-buffer-mode-hook
comint-mode-hook
term-mode-hook))))
(unless dotspacemacs-smooth-scrolling
;; deactivate smooth-scrolling advices
(ad-disable-advice 'previous-line 'after 'smooth-scroll-down)
(ad-activate 'previous-line)
(ad-disable-advice 'next-line 'after 'smooth-scroll-up)
(ad-activate 'next-line)
(ad-disable-advice 'isearch-repeat 'after 'isearch-smooth-scroll)
(ad-activate 'isearch-repeat))) |
@jramapuram If you think this may be useful for other users, you can do a PR to have it reviewed and eventually merged 😃 |
@StreakyCobra : Should be fine, however all I really did above is replace the new changes with the old ones. Not sure how this affects other packages which might require |
@jramapuram your solution works fantastically, thanks! |
Setting Edit: setting |
This is still an issue. Any chance this can be merged? I'm not too eager to dig into the internals of the layers. I am trying to convince an emacs guy to try spacemacs, as it so happened he held down the down arrow key in emacs mode and hit on this issue in the first 30 seconds of using it, making it hard to convince him :-) (for me it's less of an issue because in evil, this interestingly only shows up in insert mode, not normal mode) |
We fixed a number of smooth-scrolling problems in develop. Can someone confirm if this is fixed? |
@TheBB : Will give it a shot tomorrow! Thanks |
Fixed in 0.200 running on emacs 25.1.1 |
Description
Ctrl + n stops scrolling abruptly until release when it warps to a new location.
Issue does not happen with emacs native
Issue does not happen with Ctrl + p
Installed fresh spacemacs and see the issue.
Just in case fyi I installed emacs with brew using:
brew install emacs --with-cocoa --with-gnutls --with-rsvg --with-imagemagick --srgb
Reproduction guide
Observed behaviour:
See here: http://sendvid.com/zs96hs4j
Expected behaviour:
Smooth scrolling & no warping.
System Info
Edit: add info about Ctrl+P
The text was updated successfully, but these errors were encountered: