Problem with leuven theme and org macros

[brabalan]

Description

The face for org-macros when using the leuven theme uses a face that does not work well with hl-line-mode. This has been fixed in the leuven theme in 2014 (see fniessen/emacs-leuven-theme#25) but for some reason the fix does not work with spacemacs. Could this be a conflict with the default theme and loading order?

The problematic face is org-macro.

Reproduction guide

• Start Emacs
• use the leuven theme (I put it first in dotspacemacs-themes)
• open an org file
• enter a macro {{{foo}}}

Observed behaviour:
This is displayed:

This is the problem with hl-line-mode:

Expected behaviour:
I started a vanilla emacs with leuven theme, and it looks like this:

It works well with hl-line-mode:

(Note that the color of the highlighted line is also different.)

System Info

• OS: darwin
• Emacs: 24.5.1
• Spacemacs: 0.105.14
• Spacemacs branch: master (rev. a298a5a)
• Graphic display: t
• Distribution: spacemacs
• Editing style: vim
• Completion: helm
• Layers:

((auto-completion :variables auto-completion-enable-snippets-in-popup t auto-completion-tab-key-behavior 'cycle)
 elfeed emacs-lisp finance git gnus javascript latex ocaml org
 (spell-checking :variables spell-checking-enable-auto-dictionary t))

[cpaulik]

This might be a problem with lazy loading? Changing to the leuven theme after the org file is already loaded looks fine.

[cpaulik]

Putting (spacemacs/load-theme 'leuven) into your dotspacemacs/user-config function can be a workaround.

[brabalan]

@cpaulik Thank you for the workaround, it works.

[brabalan]

I finally managed to understand where the issue comes from. Putting the leuven theme first in dotspacemacs-themes loads the one from emacs (I guess because packages are not loaded yet), so one has to manually load the theme from user-config.