Mode-icons addition

[ReneFroger]

Check the repo mode-icons for Emacs.

I think it's benefical for Spacemacs. It makes more distinct what the major mode is. What do you think?

[syl20bnr]

Seems a nice addition if it looks nice with resizing etc... otherwise it may be considered a user setting and be used with dotspacemacs-additional-packages.

[ReneFroger]

I just tried it, and it scales well. Or perhaps do you mean else with it?

And I'm wondering why you would consider it as an user setting? It seems to me it's a nice feature. Why not consider Magit as an user setting? Or Helm? Or Spacemacs, because Spacemacs is all about custom user settings after all.

[syl20bnr]

Because we don't create layers just to wrap a package, there is the dotspacemacs-additional-packages for this.
If it looks nice (no weird and obvious graphical artefacts) we can add it to the spacemacs distribution, I'll try it to see if it fits there.

[ragloo]

it's very nice and sexy but mode-icons sadly breaks helm alignement for me

[StreakyCobra]

@ragloo Screenshot and reproduction steps would help :-)

[syl20bnr]

We can disable it in helm buffers I guess.

[ReneFroger]

How would you disable it for Helm then? I tried it but I couldn't figure it out.

[xcodebuild]

@ragloo @ReneFroger (setq mode-icons-change-mode-name nil) would disable it in helm or ido etc

BTW, I add a icon for spacemacs-buffer-mode 😂 : ryuslash/mode-icons#27

[ReneFroger]

@codefalling but.... (setq mode-icons-change-mode-name nil) will also disable it in mode line, not only in Helm/Ido buffers. There will not be a icon displayed for the major mode. What will be the point of using mode icons after all then?

I was wondering if I could disable it for Helm/Ido buffers, not for also disabling for mode line?

[xcodebuild]

@ReneFroger

(setq mode-icons-change-mode-name nil) will also disable it in mode line

Really? Everything works well in my spacemacs.

[ReneFroger]

Could you provide the same working configuration with emacs -Q?

I don't use Spacemacs, so it seems another parts of code is conflicting with yours, which will 'cause' your code to working.

[ReneFroger]

(setq mode-icons-change-mode-name nil) will also disable it in mode line

Any update on this?

[xcodebuild]

@ReneFroger Sorry for late reply

With emacs -Q

(package-initialize)
(require 'mode-icons)
(require 'helm)
(setq mode-icons-change-mode-name nil)
(mode-icons-mode)

Everything works well

[CestDiego]

bump. Is there some progress on whether we would like this? there is also now this https://github.com/domtronn/all-the-icons.el :)

[d12frosted]

Wow, @CestDiego

That package looks super nice.

[atextor]

@ReneFroger I made mode-icons work in the mode-line but not the helm buffers by adding
(remove-hook 'helm-mode-hook 'mode-icons-mode)
(remove-hook 'helm-minibuffer-set-up-hook 'mode-icons-mode)
to my dotspacemacs/user-config.

[chriskaukis]

This looks lovely! Has this been added to dev or master yet? I'm slightly on the new side to Emacs et al and can't seem to find this package in Spacemacs layers list.

[StreakyCobra]

@chriskaukis In your .spacemacs file, add mode-icons to the dotspacemacs-additional-packages list, then this somewhere in dotspacemacs/user-config:

  ;; mode-icons
  (spacemacs|do-after-display-system-init
   (mode-icons-mode))

[mustaqimM]

@StreakyCobra Is there a way to do it with all-the-icons? I'm not getting it right

[bricewge]

The author of all-the-icons is working on a theme for spaceline with this icon set: domtronn/spaceline-all-the-icons.el.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!