Popwin causes helm buffer display error in neotree window

[danielwuz]

---

This bug causes neotree-rename-node and neotree-create-node fail for those who use helm as completion system.

---

Step to reproduce:

1. open a neotree window with <leader key> f t
2. in neotree window, M-x helm-mini. An error message should display:

Window too small for splitting

---

This is caused by line 1608 in spacemacs/packages.el,

(push '("^\*helm.+\*$" :regexp t  :position bottom) popwin:special-display-config)

Not sure what we use popwin with helm for. Is it possible to remove helm from popwin?

[syl20bnr]

@danielwuz I retried without popwin and I don't like the default behaviour where helm can be at different places. Tell me if you find a way to make it appears always at the same position.

For now I let popwin for helm, but don't worry I added a function to easily disable this in your ~/.spacemacs. See 2) of https://github.com/syl20bnr/spacemacs#tips-for-spacemacs-advanced-users

[danielwuz]

@syl20bnr I also dislike the idea that helm shows up at different places. Can you try with below settings?

(setq helm-split-window-in-side-p nil
      helm-always-two-windows t
      neo-persist-show nil
)

This settings should give you a dedicated helm buffer that always show at bottom.

Thanks for making it so easy to get helm along with popwin for me. will try it out.

[syl20bnr]

@danielwuz Just tried it, works like a charm, I may use NeoTree as a quick way to navigate a project tree, I made some improvements for NeoTree in v0.3.2. Thank you! 👍

I'm waiting for your PR with your configuration proposal :-)
You can also remove the popwin line for helm.