cljr-refactor in Clojure layer breaks Cider ClojureScript REPL

[kthu]

Description

If cljr-refactor is installed, Cider will get confused about the type of REPL it has spawned when doing [SPC m s I], causing it to connect to the Clojure REPL instead of the ClojureScript REPL.

This makes it impossible to eval stuff from the editor buffer. Evaling by typing directly into the ClojureScript REPL works fine, so the REPL itself is ok.

This problem has been showing up from time to time, and it seems to have been reintroduced with the latest Cider update (20160612.1230). The latest Cider contained a patch that was supposed to work around the problem: clojure-emacs/cider@e2f9ffd

Commenting out the clj-refactor related lines from layers/+lang/clojure/packages.el and deleting the clj-refactor package from the elpa directory fixes the problem. (Is there a cleaner way to do this?)

Reproduction guide

• Start Emacs
• Open a file from a cljs project
• [SPC m s I]
• Try to eval a form

Observed behaviour:
Cider complains:
The ClojureScript REPL seems to be is misbehaving. We have applied a workaround, but please also file a bug report with [cider-report-bug] Press any key to continue.

or

user-error: 'cider-eval-defun-at-point' needs a ClojureScript REPL. If you don't know what that means, you probably need to jack-in ('C-c M-j').

and the evaluation fails, trying to use the wrong REPL.

Expected behaviour:
Form should be evaluated

System Info

• OS: gnu/linux
• Emacs: 24.5.1
• Spacemacs: 0.105.21
• Spacemacs branch: master (rev. 0283f64)
• Graphic display: t
• Distribution: spacemacs
• Editing style: vim
• Completion: helm
• Layers:

(html auto-completion better-defaults emacs-lisp git markdown clojure javascript org syntax-checking version-control)

[kthu]

Fixed in cider-nrepl just now: clojure-emacs/cider#1611 (comment)