Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranger preview/spaceline redraw issue #6894

Closed
arronmabrey opened this issue Aug 22, 2016 · 4 comments
Closed

Ranger preview/spaceline redraw issue #6894

arronmabrey opened this issue Aug 22, 2016 · 4 comments
Labels
- Bug tracker - stale marked as a stale issue/pr (usually by a bot) Visual

Comments

@arronmabrey
Copy link
Contributor

arronmabrey commented Aug 22, 2016

Description :octocat:

Ranger preview/spaceline redraw issue

Reproduction guide 🪲 [updated]

  • git clone https://github.com/syl20bnr/spacemacs ~/.emacs.d
  • checkout current master [9f9faa4] or current develop [b8ca74e] (verified with both)
  • start spacemacs for first time and accept defaults
  • edit generated .spacemacs file with the following diff
diff --git a/.spacemacs b/.spacemacs
index 170910c..030dd92 100644
--- a/.spacemacs
+++ b/.spacemacs
@@ -34,7 +34,10 @@ values."
      ;;        shell-default-position 'bottom)
      ;; spell-checking
      ;; syntax-checking
-     ;; version-control
+     version-control
+     (ranger :variables
+             ranger-show-literal nil
+             ranger-show-preview t)
      )
    ;; List of additional packages that will be installed without being
    ;; wrapped in a layer. If you need some configuration for these
@@ -206,7 +209,7 @@ values."
    ;; If non nil line numbers are turned on in all `prog-mode' and `text-mode'
    ;; derivatives. If set to `relative', also turns on relative line numbers.
    ;; (default nil)
-   dotspacemacs-line-numbers nil
+   dotspacemacs-line-numbers t
    ;; If non-nil smartparens-strict-mode will be enabled in programming modes.
    ;; (default nil)
    dotspacemacs-smartparens-strict-mode nil
  • quit/relaunch spacemacs
  • invoke ranger SPC a r and preview files (I previewed the core spacemacs elisp file, but any should work)

Observed behaviour: 👀 💔
spacemacs-ranger-bug

Expected behaviour: ❤️ 😄
not that ^^^ ;-)

System Info 💻

Note: these values may no longer apply / I have reproduced with fresh installs as detailed above

  • OS: darwin
  • Emacs: 24.5.1
  • Spacemacs: 0.105.22
  • Spacemacs branch: develop (rev. 4071e0c)
  • Graphic display: nil
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(auto-completion better-defaults clojure emacs-lisp fasd git github gtags javascript themes-megapack markdown
                 (ranger :variables ranger-show-literal nil ranger-show-preview t)
                 (ruby :variables ruby-version-manager 'rbenv ruby-test-runner 'rspec)
                 theming org react
                 (shell :variables shell-default-height 40 shell-default-position 'bottom shell-default-shell 'multi-term shell-default-term-shell "/bin/zsh")
                 spell-checking syntax-checking
                 (version-control :variables version-control-global-margin t version-control-diff-tool 'git-gutter))
@arronmabrey
Copy link
Contributor Author

I cloned a fresh copy of master with a default generated .spacemacs file and this bug is not present. I switched to the latest develop with the fresh .spacemacs file and the bug is not present. So it must be something in my config. I try to isolate it and report back.

@arronmabrey
Copy link
Contributor Author

Here are the distilled reproduction steps using both fresh install of current master OR current develop.

  • git clone https://github.com/syl20bnr/spacemacs ~/.emacs.d
  • checkout current master [9f9faa4] or current develop [b8ca74e] (verified with both)
  • start spacemacs for first time and accept defaults
  • edit generated .spacemacs file with the following diff
diff --git a/.spacemacs b/.spacemacs
index 170910c..030dd92 100644
--- a/.spacemacs
+++ b/.spacemacs
@@ -34,7 +34,10 @@ values."
      ;;        shell-default-position 'bottom)
      ;; spell-checking
      ;; syntax-checking
-     ;; version-control
+     version-control
+     (ranger :variables
+             ranger-show-literal nil
+             ranger-show-preview t)
      )
    ;; List of additional packages that will be installed without being
    ;; wrapped in a layer. If you need some configuration for these
@@ -206,7 +209,7 @@ values."
    ;; If non nil line numbers are turned on in all `prog-mode' and `text-mode'
    ;; derivatives. If set to `relative', also turns on relative line numbers.
    ;; (default nil)
-   dotspacemacs-line-numbers nil
+   dotspacemacs-line-numbers t
    ;; If non-nil smartparens-strict-mode will be enabled in programming modes.
    ;; (default nil)
    dotspacemacs-smartparens-strict-mode nil
  • quit/relaunch spacemacs
  • invoke ranger SPC a r and preview files (I previewed the core spacemacs elisp file, but any should work)

@rjhilgefort
Copy link

I'm seeing something similar, but my buffers are affected as well.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Bug tracker - stale marked as a stale issue/pr (usually by a bot) Visual
Projects
None yet
Development

No branches or pull requests

3 participants