Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next layout spacemacs buffer issue #7317

Closed
vendethiel opened this issue Oct 7, 2016 · 16 comments
Closed

Next layout spacemacs buffer issue #7317

vendethiel opened this issue Oct 7, 2016 · 16 comments

Comments

@vendethiel
Copy link

vendethiel commented Oct 7, 2016

Note: I set up the template manually because the in-editor one doesn't seem to work. Maybe it's just because I didn't configure Org mode yet...

Description :octocat:

Switching workspace with SPC l n doesn't close the menu.

Reproduction guide 🪲

  • Start Emacs
    SPC l 2
    It asks me about perspective (wtf is that, even?)
    I say I want to create one (well, it's a non-question really, if I say no it cancels the action)
    It asks me the name of the perspective (what am I supposed to set here?). I just set persp-frame-switch otherwise the action is canceled as well.
    SPC l n to switch to the next layout.

Observed behaviour: 👀 💔
The switch happens, but the *spacemacs* buffer doesn't close, and shows "layouts transient state" until I press a key

Expected behaviour: ❤️ 😄
The spacemacs buffer should close.


macOS 10.12 Sierra
Spacemacs e6357a5

@JAremko
Copy link
Collaborator

JAremko commented Oct 7, 2016

SPC l 2 will create a new perspective with a specified name. Then you can use SPC l n to switch between the new one and the default one. What is the problem 😕

@vendethiel
Copy link
Author

Looks like the description I pasted was truncated.

I understand the part about names (why is that needed?)

I do think that the spacemacs buffer not closing until next keystroke is a bug

@TheBB
Copy link
Contributor

TheBB commented Oct 7, 2016

I don't understand this report either. Why would the window show any other buffer in a completely new perspective.

@bmag
Copy link
Contributor

bmag commented Oct 7, 2016

@vendethiel please edit the original report to include the observed behavior and the expected behavior. Right now I don't understand what you're trying to say.

In the repro guide, describe clearly the steps you do take to experience the observed behavior. You can add comments, but make it clear what keys you pressed. For example, when you write "I just set persp-frame-switch", I have no idea what you mean or what keys I need to press.

@JAremko
Copy link
Collaborator

JAremko commented Oct 7, 2016

I understand the part about names (why is that needed?)

For humans. This is much easier to manage named stuff. You are entering the naming buffer automatically but you can provide one letter name or hack it to auto generate names - may be supported out of the box, by the underlying package.

I do think that the spacemacs buffer not closing until next keystroke is a bug

you can use SPC l 2 for fast switching. SPC l n keeps you in the transient state so consequential n will keep rotating perspectives.

@vendethiel
Copy link
Author

@bmag I'm afraid github mobile (still) doesn't allow to edit.

@vendethiel
Copy link
Author

@JAremko I see. I guess it somewhat makes sense (though it's a very very surprising behavior. YMMV, as usual, I've just had a hard time understanding how to get a setup like vim tabs on spacemacs, so I'm trying a lot of stuff...)

@bmag
Copy link
Contributor

bmag commented Oct 7, 2016

@vendethiel ok, will be waiting then

@JAremko
Copy link
Collaborator

JAremko commented Oct 7, 2016

@JAremko
Copy link
Collaborator

JAremko commented Oct 7, 2016

@bmag Can we add a flag that if t will make perspective mode auto-generate names? Like Docker does if a name isn't provided. We can grab some catchy names from https://github.com/docker/docker/blob/master/pkg/namesgenerator/names-generator.go. Like prickly beaver - sounds great 😄

@bmag
Copy link
Contributor

bmag commented Oct 7, 2016

@JAremko I will look into it. I'm thinking about matching the first letter of each name to the layout's number, so layout 2 starts with "b", 3 with "c", etc. so we can have names like: "Default" (1), "banana" (2), "carrot" (3), and so on.

@JAremko
Copy link
Collaborator

JAremko commented Oct 7, 2016

@bmag It's cool. But I think that there is something to docker naming patter. When you use adjective(or a verb) + noun it creates a mental context (backstory) so it automatically more memorable. And often funny 😄

@TheBB
Copy link
Contributor

TheBB commented Oct 7, 2016

The layout name will be in the modeline though, so let's try to keep them short.

@JAremko
Copy link
Collaborator

JAremko commented Oct 7, 2016

@TheBB good point. Mb we can shorten the name if modeling becomes "crowded"? Fist shorten from two words to the first one like prickly b or prickly and if it is really crowded to pb.

@bmag
Copy link
Contributor

bmag commented Oct 8, 2016

@JAremko see #7323. Instead of "adjective+noun" I went for "familiar objects" naming style.

@vendethiel
Copy link
Author

SPC l n keeps you in the transient state so consequential n will keep rotating perspectives.

Okay, I think that's the answer I was looking for. It was pretty confusing, even more so because that's not how gt works on vim.

Going to close this one now! Thanks y'all.

Also updated the original post, just to make it clear to whoever comes back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants