-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evil-org must not be installed if editing style is emacs #9713
Comments
Well you can switch between holy mode (emacs) and evil mode (vim) at any time (just press |
@SDWolf It should be just as easy to install missing packages on the fly when user switches to evil mode. There shouldn't be a need to clutter the user's dir with packages they are never going to use. Additionally I don't use spacemacs and was just working on getting this PR ( #9705 ) in for spacemacs + ox-hugo users... and the whole process became cumbersome with errors like "Symbol's function definition is void: evil-org-mode" ( #9618 ). Why should I be bothered with |
@SDWolf |
I see, thank you for your observations, I'l take a look at both of them, but I can't prommise I will find a fix. |
@kaushalmodi can you please check #9716 to see if it fixes your problem? @duianto Not sure if this is something I should contribute to the core, I'l leave it to you. |
@SDWolf Thanks for looking into it. I don't really have a preference, I just thought that Emacs style users might want the key bindings to be as close to what they are used to as possible. There seems to be at least two ways that
If the second option is chosen, then But I suspect that the second option, means that the evil packages also would have to be installed when the Since it's been broken for 6 years, then it might not be a very often used key binding, or someone probably would have reported it. Still, it should probably not be left for another 6 years, as just a key binding that prints |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid! |
Description
Spacemacs attempts to install evil-org when when my editing style is emacs!
Reproduction guide 🪲
org
layerObserved behaviour: 👀 💔
Expected behaviour: ❤️ 😄
evil-org must not be installed if my editing style is emacs
System Info 💻
(helm emacs-lisp neotree org)
The text was updated successfully, but these errors were encountered: