Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all settings reset after update! #40

Open
Owyn opened this issue Feb 11, 2022 · 6 comments
Open

all settings reset after update! #40

Owyn opened this issue Feb 11, 2022 · 6 comments
Labels
config opts Related to configuration options, config files, or keymap files enhancement New feature or request

Comments

@Owyn
Copy link

Owyn commented Feb 11, 2022

extracted new version to old versions place and now all my settings got reset to default... cuz archive had JPEGView.ini and KeyMap.txt 😢

@sylikc
Copy link
Owner

sylikc commented Feb 11, 2022

That's how the author had it by default... I'm not sure what it could be changed to... JPEGView is in some weird state if you run without the INI...

@sylikc
Copy link
Owner

sylikc commented Feb 11, 2022

I think the best approach would be to have a multi-layered configuration read... but I'm not sure how that would interact with the existing KeyMap and stuff....

basically read the default JPEGView.ini. ... template maybe...
and then read anything that overwrites that as a user setting...

@sylikc
Copy link
Owner

sylikc commented Feb 11, 2022

@Owyn I'm currently working on an installer as requested here #32 (comment) ... That will solve the problem with the INI but I'm still not sure it'll solve the KeyMap problem

@sylikc sylikc added the enhancement New feature or request label Feb 11, 2022
@Owyn
Copy link
Author

Owyn commented Feb 12, 2022

I'm not sure what it could be changed to

Not having settings files in the installer archive, then when the program is launched - create those from a template if not present, else insert new (missing) settings if created in the latest update

I think many (if not most?) programs do that, https://github.com/Nandaka/PixivUtil2/ for example

@donatasben
Copy link

donatasben commented Mar 7, 2022

The original Readme states that there can be two settings .ini files:

  • User INI file at C:\Users\Username\AppData\roaming\JPEGView\JPEGView.ini (path name depends on Windows version) - copy your customized file there if it doesn't exist.
  • Global INI file [Path of JPEGView.exe]\JPEGView.ini

So if you want to customize the settings, you should do it in the %appdata%\JPEGView\ file.

However this doesn't apply to the Keymap.txt file... But maybe it could be done in the same fashion?

@sylikc
Copy link
Owner

sylikc commented Mar 17, 2022

So there is also a command line parameter /ini which allows you to specify an INI file to use.

I'm going to see if I can get the KEYMAP.TXT to work the same way. the JPEGView.ini and JPEGView.ini.tpl have gotten out of sync, so I'm reviewing that as well.

I'll try getting the keymap.txt to cascade through user settings. It will be the focus of the next feature update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config opts Related to configuration options, config files, or keymap files enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants