Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support ./dr.sh vendor/bin/phpunit or similar #4

Open
silbinarywolf opened this issue Jul 26, 2018 · 3 comments
Open
Assignees

Comments

@silbinarywolf
Copy link
Contributor

Why?
Simpler mapping to how you might execute phpunit, phpstan, etc.
I keep having to jump back into the docs and remembering the ./dr.sh php exec command.

When we developers use thirdparty tools like vendor/bin things, they should be able to follow the documentation and just prefix ./dr.sh

How?

  • If $cmd contains at start of first argument "vendor/bin/"
  • If "vendor/bin" folder exists, proceed to next step, if not show message:
    • "Error, unable to find vendor/bin folder. Have you run composer install? Is this a PHP project?"
  • Drop into phpcli and execute that command.
@silbinarywolf
Copy link
Contributor Author

@nyeholt If you have no problem with this going in, I'm happy to PR it.

@silbinarywolf
Copy link
Contributor Author

Gave it a bit more thought, this might be over-reaching a bit.

Maybe something to detect this case, and then it teaches the dev how to shell into their container and execute that command.

That way the person gets more of an understanding of how Docker stuff works.

@nglasl
Copy link
Contributor

nglasl commented Jan 7, 2019

@nyeholt could you please provide some input here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants