-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getNestedConfig()
called on the parent but should be called on the child
#394
Comments
Issue was solved. Task is completed. |
FYI @forsdahl I didn't pick up on this during the initial PR, but when looking at the problems Sabina was hitting getting this set up for behat tests I realised this would be a lot more intuitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current state means that a parent is responsible for its children's nested config. This isn't intuitive. Each class should be responsible for its own nested config (i.e. responsible for determining how to show its own children).
PRs
The text was updated successfully, but these errors were encountered: