Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node list should not be hardcoded #1735

Closed
cryptoBeliever opened this issue Oct 11, 2021 · 0 comments · Fixed by #1755
Closed

Node list should not be hardcoded #1735

cryptoBeliever opened this issue Oct 11, 2021 · 0 comments · Fixed by #1755
Assignees
Labels
enhancement New feature or request

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Oct 11, 2021

Currently, the default node list is hard-coded and we should change that.
The proposition is:

  • use statistics service (currently ec2-34-222-209-211.us-west-2.compute.amazonaws.com:4001 but there will be dedicated DNS)
  • currently, we have available endpoints:
/nodes
/nodes/<publicKey>

/nodesHostDetail
/nodeStats
/nodeHeightStats
/timeSeries/nodeCount

The endpoint list can change. We can add new endpoints (for example find by nodePublicKey could be very helpful on harvesting page) if it will be useful, we can add information to node info like if it supports harvesting and so on. Whatever will be help wallet.

  • on harvesting view, we should allow user filter as is now but based on list from statistics service
  • wallet nodes should be taken from node statistics service based on user region / locale (if possible without location permission)
@cryptoBeliever cryptoBeliever added the enhancement New feature or request label Oct 11, 2021
@bassemmagdy bassemmagdy self-assigned this Oct 29, 2021
This was referenced Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants