Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My Contacts - Not possible to edit address #1834

Closed
cryptoBeliever opened this issue Jan 26, 2022 · 4 comments · Fixed by #1847
Closed

My Contacts - Not possible to edit address #1834

cryptoBeliever opened this issue Jan 26, 2022 · 4 comments · Fixed by #1847
Assignees
@OlegMakarenko
Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Jan 26, 2022 •
edited
Loading

Affected version: 1.0.9

Steps:

  1. Create a contact in the address book.
  2. Choose it.
  3. Try edit address.

Result:
Edit input is closed but the address won't change.

Expected result:

  1. User should be able to edit address.
  2. Wallet should verify if provided address is valid.
  3. Wallet should verify if provided address does not exist already in the address book.

Video: https://share.getcloudapp.com/llu66Rb0
@cryptoBeliever cryptoBeliever added the P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action label Jan 29, 2022
@OlegMakarenko OlegMakarenko self-assigned this Feb 16, 2022
@OlegMakarenko OlegMakarenko mentioned this issue Feb 16, 2022
Merged
@OlegMakarenko OlegMakarenko linked a pull request Feb 16, 2022 that will close this issue
fix: address book #1847
Merged
@cryptoBeliever
Copy link
Contributor Author

cryptoBeliever commented Feb 17, 2022 •
edited
Loading

@OlegMakarenko each address in address book should be unique. Currently using editing (when I'm adding there is validation) I'm able to have two contacts with same.
Video: https://share.getcloudapp.com/E0uoQNjY

@OlegMakarenko
Copy link
Contributor

@cryptoBeliever fixed, but there is also another issue with updating contact. WTR:

  1. Select contact.
  2. Change name to A.
  3. Change address to a different one.
  4. Change name to B.
  5. Change address to a different one.
  6. Name automaticaly changes to A

Working on it.

@cryptoBeliever
Copy link
Contributor Author

Fixed in #1847

@OlegMakarenko OlegMakarenko mentioned this issue Aug 17, 2022
Merged
@yilmazbahadir yilmazbahadir mentioned this issue Aug 19, 2022
Merged
@ymuichiro ymuichiro mentioned this issue Aug 20, 2022
Closed
@cryptoBeliever
Copy link
Contributor Author

Released in 1.0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlegMakarenko OlegMakarenko

Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: address book OlegMakarenko/symbol-desktop-wallet
2 participants
@cryptoBeliever @OlegMakarenko