Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction details - address should be clickable and show account details in explorer #1843

Closed
cryptoBeliever opened this issue Feb 14, 2022 · 4 comments · Fixed by #1847
Closed
Assignees

Comments

@cryptoBeliever
Copy link
Contributor

Current state:
Currently, in transaction details, all addresses are not clickable. But it would be good for the user to allow click it (same as transaction hash) to see account details in the explorer. Same for a contact name for resolved addresses.

image

@OlegMakarenko OlegMakarenko self-assigned this Feb 15, 2022
@OlegMakarenko OlegMakarenko linked a pull request Feb 16, 2022 that will close this issue
@cryptoBeliever
Copy link
Contributor Author

@OlegMakarenko I thought about the same thing as we have for transaction hash (just link). You did in this way to allow show address even if it's replaced by contact name?

@OlegMakarenko
Copy link
Contributor

OlegMakarenko commented Feb 17, 2022

@cryptoBeliever

You did in this way to allow show address even if it's replaced by contact name

Yes, you are right. Also I would like to show the button which will let the user know that it will take them outside the app.
One thing I don't like is that it is popup on top of other popup (modal). Thinking about, maybe we can replace it with icon or something next to address.

Do you think we should make it the same it was done for hash?

@cryptoBeliever
Copy link
Contributor Author

The current solution looks good 👍 We have the option to open in explorer and copy the address.

image

Fixed in #1847

@cryptoBeliever
Copy link
Contributor Author

Released in 1.0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants