Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "ToS" and "Privacy Policy" links to Settings Screen. #814

Closed
cryptoBeliever opened this issue Dec 12, 2020 · 5 comments · Fixed by #1691
Closed

Add "ToS" and "Privacy Policy" links to Settings Screen. #814

cryptoBeliever opened this issue Dec 12, 2020 · 5 comments · Fixed by #1691
Assignees
@AnthonyLaw
Labels
Desktop Sprint 4

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Dec 12, 2020 •
edited
Loading

When creating a wallet user can read terms and privacy policy.
After wallet is created there is no way to open it again. I think there should be links somewhere in wallet allowing opening it.
@cryptoBeliever cryptoBeliever added enhancement New feature or request P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action and removed P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action labels Dec 12, 2020
@coiki coiki added Desktop Sprint 4 and removed enhancement New feature or request labels Aug 27, 2021
@coiki coiki changed the title Add possibility to view terms and privacy policy after profile creation Add "ToS" and "Privacy Policy" links to Settings Screen. Aug 27, 2021
@coiki
Copy link

coiki commented Aug 27, 2021

User Story

As a user that already has created an account and entered the wallet,
I want to have access to read the Terms of Service and the Privacy Policy links,
so I can consult them whenever I feel like it.

Acceptance Criteria

AC1. Inside the Settings screen (cog icon), in the About tab, and below "Homepage", 2 items will be added. One labeled "Terms of Service" and another one labeled "Privacy Policy".
AC2. Next to "Terms of Service" we will display a link to our Terms of Service.
AC3. Next to "Privacy Policy" we will display a link to our Privacy Policy.
AC4. User can close Terms of Service or Privacy Policy and return to the settings screen.

@coiki
Copy link

coiki commented Aug 27, 2021

Area to add the links:
image

@AnthonyLaw AnthonyLaw self-assigned this Sep 2, 2021
@AnthonyLaw
Copy link
Member

Tos and Privacy Policy actually are Vue components.

I don't think that is a good idea to place it under About Tab.

Screenshot 2021-09-02 at 6 29 09 PM

What do you think if we put it under the bottom?
Screenshot 2021-09-02 at 6 38 45 PM

@cryptoBeliever
Copy link
Contributor Author

cryptoBeliever commented Sep 2, 2021 •
edited
Loading

@AnthonyLaw Looks good to me 👍

@AnthonyLaw AnthonyLaw linked a pull request Sep 2, 2021 that will close this issue
fix: add term and policy to bottom. #1691
Merged
@cryptoBeliever
Copy link
Contributor Author

Fixed in dev 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnthonyLaw AnthonyLaw

Labels
Desktop Sprint 4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add term and policy to bottom. symbol/desktop-wallet
3 participants
@coiki @AnthonyLaw @cryptoBeliever