remove ability to access $this and the loader's internal state

Author: xabbuh

CHANGELOG.md

@@ -4,6 +4,7 @@ CHANGELOG
 8.0
 ---
 
+ * Remove support for accessing the internal scope of the loader in PHP config files, use only its public API instead
  * Add argument `$singular` to `NodeBuilder::arrayNode()`
  * Add argument `$info` to `ArrayNodeDefinition::canBeDisabled()` and `canBeEnabled()`
 

Definition/Loader/DefinitionFileLoader.php

@@ -48,17 +48,7 @@ public function load(mixed $resource, ?string $type = null): mixed
             return include $file;
         }, null, null);
 
-        try {
-            $callback = $load($path);
-        } catch (\Error $e) {
-            $load = \Closure::bind(static function ($file) use ($loader) {
-                return include $file;
-            }, null, ProtectedDefinitionFileLoader::class);
-
-            $callback = $load($path);
-
-            trigger_deprecation('symfony/config', '7.4', 'Accessing the internal scope of the loader in config files is deprecated, use only its public API instead in "%s" on line %d.', $e->getFile(), $e->getLine());
-        }
+        $callback = $load($path);
 
         if (\is_object($callback) && \is_callable($callback)) {
             $this->callConfigurator($callback, new DefinitionConfigurator($this->treeBuilder, $this, $path, $resource), $path);

Tests/Definition/Loader/DefinitionFileLoaderTest.php

@@ -11,8 +11,6 @@
 
 namespace Symfony\Component\Config\Tests\Definition\Loader;
 
-use PHPUnit\Framework\Attributes\Group;
-use PHPUnit\Framework\Attributes\IgnoreDeprecations;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Config\Definition\BaseNode;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
@@ -41,15 +39,4 @@ public function testLoad()
         $this->assertInstanceOf(BaseNode::class, $children['foo']);
         $this->assertSame('test.foo', $children['foo']->getPath(), '->load() loads a PHP file resource');
     }
-
-    #[IgnoreDeprecations]
-    #[Group('legacy')]
-    public function testTriggersDeprecationWhenAccessingLoaderInternalScope()
-    {
-        $loader = new DefinitionFileLoader(new TreeBuilder('test'), new FileLocator(__DIR__.'/../../Fixtures/Loader'));
-
-        $this->expectUserDeprecationMessageMatches('{^Since symfony/config 7.4: Accessing the internal scope of the loader in config files is deprecated, use only its public API instead in ".+" on line \d+\.$}');
-
-        $loader->load('legacy_internal_scope.php');
-    }
 }