do not pass the empty string to ord()

xabbuh · xabbuh · commit 492de6dfd939 · 2025-09-26T14:13:46.000+02:00
diff --git a/Helper/QuestionHelper.php b/Helper/QuestionHelper.php
@@ -317,7 +317,7 @@ private function autocomplete(OutputInterface $output, Question $question, $inpu
                     $ofs += ('A' === $c[2]) ? -1 : 1;
                     $ofs = ($numMatches + $ofs) % $numMatches;
                 }
-            } elseif (\ord($c) < 32) {
+            } elseif ('' === $c || \ord($c) < 32) {
                 if ("\t" === $c || "\n" === $c) {
                     if ($numMatches > 0 && -1 !== $ofs) {
                         $ret = (string) $matches[$ofs];

Original file line number	Diff line number	Diff line change
`@@ -317,7 +317,7 @@ private function autocomplete(OutputInterface $output, Question $question, $inpu`
`317`	`317`	`$ofs += ('A' === $c[2]) ? -1 : 1;`
`318`	`318`	`$ofs = ($numMatches + $ofs) % $numMatches;`
`319`	`319`	`}`
`320`		`- } elseif (\ord($c) < 32) {`
	`320`	`+ } elseif ('' === $c \|\| \ord($c) < 32) {`
`321`	`321`	`if ("\t" === $c \|\| "\n" === $c) {`
`322`	`322`	`if ($numMatches > 0 && -1 !== $ofs) {`
`323`	`323`	`$ret = (string) $matches[$ofs];`