feature #1391 Add Symfony and Doctrine PHPStan extensions (ker0x)

This PR was squashed before being merged into the main branch.

Discussion
----------

Add Symfony and Doctrine PHPStan extensions

Fix #1379

Commits
-------

0712760 Add Symfony and Doctrine PHPStan extensions

composer.json

@@ -49,7 +49,10 @@
     "require-dev": {
         "dama/doctrine-test-bundle": "^7.0",
         "doctrine/doctrine-fixtures-bundle": "^3.4",
+        "phpstan/extension-installer": "^1.2",
         "phpstan/phpstan": "^1.2",
+        "phpstan/phpstan-doctrine": "^1.3",
+        "phpstan/phpstan-symfony": "^1.2",
         "symfony/browser-kit": "^6.2",
         "symfony/css-selector": "^6.2",
         "symfony/debug-bundle": "^6.2",
@@ -61,7 +64,8 @@
     "config": {
         "allow-plugins": {
             "symfony/flex": true,
-            "symfony/runtime": true
+            "symfony/runtime": true,
+            "phpstan/extension-installer": true
         },
         "platform": {
             "php": "8.1.0"

config/services.yaml

@@ -34,9 +34,3 @@ services:
         $sender: '%app.notifications.email_sender%'
 
     Symfony\Component\Security\Http\Logout\LogoutUrlGenerator: '@security.logout_url_generator'
-
-when@test:
-    services:
-        test.user_password_hasher:
-            alias: 'security.user_password_hasher'
-            public: true

phpstan-baseline.neon

@@ -1,5 +1,65 @@
 parameters:
 	ignoreErrors:
+		-
+			message: "#^Property App\\\\Entity\\\\Comment\\:\\:\\$author type mapping mismatch\\: property can contain App\\\\Entity\\\\User\\|null but database expects App\\\\Entity\\\\User\\.$#"
+			count: 1
+			path: src/Entity/Comment.php
+
+		-
+			message: "#^Property App\\\\Entity\\\\Comment\\:\\:\\$content type mapping mismatch\\: property can contain string\\|null but database expects string\\.$#"
+			count: 1
+			path: src/Entity/Comment.php
+
+		-
+			message: "#^Property App\\\\Entity\\\\Comment\\:\\:\\$post type mapping mismatch\\: property can contain App\\\\Entity\\\\Post\\|null but database expects App\\\\Entity\\\\Post\\.$#"
+			count: 1
+			path: src/Entity/Comment.php
+
+		-
+			message: "#^Property App\\\\Entity\\\\Post\\:\\:\\$author type mapping mismatch\\: property can contain App\\\\Entity\\\\User\\|null but database expects App\\\\Entity\\\\User\\.$#"
+			count: 1
+			path: src/Entity/Post.php
+
+		-
+			message: "#^Property App\\\\Entity\\\\Post\\:\\:\\$content type mapping mismatch\\: property can contain string\\|null but database expects string\\.$#"
+			count: 1
+			path: src/Entity/Post.php
+
+		-
+			message: "#^Property App\\\\Entity\\\\Post\\:\\:\\$slug type mapping mismatch\\: property can contain string\\|null but database expects string\\.$#"
+			count: 1
+			path: src/Entity/Post.php
+
+		-
+			message: "#^Property App\\\\Entity\\\\Post\\:\\:\\$summary type mapping mismatch\\: property can contain string\\|null but database expects string\\.$#"
+			count: 1
+			path: src/Entity/Post.php
+
+		-
+			message: "#^Property App\\\\Entity\\\\Post\\:\\:\\$title type mapping mismatch\\: property can contain string\\|null but database expects string\\.$#"
+			count: 1
+			path: src/Entity/Post.php
+
+		-
+			message: "#^Property App\\\\Entity\\\\User\\:\\:\\$email type mapping mismatch\\: property can contain string\\|null but database expects string\\.$#"
+			count: 1
+			path: src/Entity/User.php
+
+		-
+			message: "#^Property App\\\\Entity\\\\User\\:\\:\\$fullName type mapping mismatch\\: property can contain string\\|null but database expects string\\.$#"
+			count: 1
+			path: src/Entity/User.php
+
+		-
+			message: "#^Property App\\\\Entity\\\\User\\:\\:\\$password type mapping mismatch\\: property can contain string\\|null but database expects string\\.$#"
+			count: 1
+			path: src/Entity/User.php
+
+		-
+			message: "#^Property App\\\\Entity\\\\User\\:\\:\\$username type mapping mismatch\\: property can contain string\\|null but database expects string\\.$#"
+			count: 1
+			path: src/Entity/User.php
+
 		-
 			message: "#^Parameter \\#1 \\$function of class ReflectionFunction constructor expects Closure\\|string, callable\\(\\)\\: mixed given\\.$#"
 			count: 1

phpstan.neon.dist

@@ -8,3 +8,7 @@ parameters:
         - tests
     bootstrapFiles:
         - vendor/bin/.phpunit/phpunit/vendor/autoload.php
+    doctrine:
+        objectManagerLoader: tests/object-manager.php
+    symfony:
+        containerXmlPath: var/cache/dev/App_KernelDevDebugContainer.xml

src/Controller/BlogController.php

@@ -156,7 +156,7 @@ public function commentForm(Post $post): Response
     public function search(Request $request, PostRepository $posts): Response
     {
         $query = (string) $request->query->get('q', '');
-        $limit = (int) $request->query->get('l', 10);
+        $limit = $request->query->getInt('l', 10);
 
         if (!$request->isXmlHttpRequest()) {
             return $this->render('blog/search.html.twig', ['query' => $query]);

tests/Command/AddUserCommandTest.php

@@ -92,7 +92,7 @@ private function assertUserCreated(bool $isAdmin): void
         $repository = $this->getContainer()->get(UserRepository::class);
 
         /** @var UserPasswordHasherInterface $passwordHasher */
-        $passwordHasher = $this->getContainer()->get('test.user_password_hasher');
+        $passwordHasher = $this->getContainer()->get(UserPasswordHasherInterface::class);
 
         $user = $repository->findOneByEmail($this->userData['email']);
 

tests/object-manager.php

@@ -0,0 +1,22 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+use App\Kernel;
+use Symfony\Component\Dotenv\Dotenv;
+
+require dirname(__DIR__).'/vendor/autoload.php';
+
+(new Dotenv())->bootEnv(dirname(__DIR__).'/.env');
+
+$kernel = new Kernel($_SERVER['APP_ENV'], (bool) $_SERVER['APP_DEBUG']);
+$kernel->boot();
+
+return $kernel->getContainer()->get('doctrine')->getManager();