You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Stumbled over that add-lines implemented in #975 is now used not only for phpunit.xml.dist files or .js, ... files but also for config recipes files.
Sadly used for config/packages/.. or config/routes/.. I personally would avoid using that and have another mechanism there.
Maybe merged .yaml or even own notifier_...yaml would be better there.
This kind of configurations can currently this way not be converted to PHP based recipes. And I don't see a way for do it, without somebody need todo this manually for every recipe.
Stumbled over that
add-lines
implemented in #975 is now used not only forphpunit.xml.dist
files or.js
, ... files but also for config recipes files.Sadly used for
config/packages/..
orconfig/routes/..
I personally would avoid using that and have another mechanism there.Maybe merged
.yaml
or even ownnotifier_...yaml
would be better there.This kind of configurations can currently this way not be converted to
PHP
based recipes. And I don't see a way for do it, without somebody need todo this manually for every recipe.This recipe patches will so fail on PHP based config recipes repo currently: https://github.com/schranz-php-recipes/symfony-recipes-php/pull/44/files#
The text was updated successfully, but these errors were encountered: