Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-lines patcher can not be converted from .yaml to .php #984

Open
alexander-schranz opened this issue Jun 21, 2023 · 0 comments
Open

Add-lines patcher can not be converted from .yaml to .php #984

alexander-schranz opened this issue Jun 21, 2023 · 0 comments

Comments

@alexander-schranz
Copy link
Contributor

alexander-schranz commented Jun 21, 2023

Stumbled over that add-lines implemented in #975 is now used not only for phpunit.xml.dist files or .js, ... files but also for config recipes files.

Sadly used for config/packages/.. or config/routes/.. I personally would avoid using that and have another mechanism there.

Maybe merged .yaml or even own notifier_...yaml would be better there.

This kind of configurations can currently this way not be converted to PHP based recipes. And I don't see a way for do it, without somebody need todo this manually for every recipe.

This recipe patches will so fail on PHP based config recipes repo currently: https://github.com/schranz-php-recipes/symfony-recipes-php/pull/44/files#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant