[make:user] add class name for UniqueConstraint

Author: seb-jean

src/Maker/MakeUser.php

@@ -162,7 +162,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
 
         $manipulator->setIo($io);
 
-        $this->userClassBuilder->addUserInterfaceImplementation($manipulator, $userClassConfiguration);
+        $this->userClassBuilder->addUserInterfaceImplementation($manipulator, $userClassConfiguration, $userClassNameDetails->getShortName());
 
         $generator->dumpFile($classPath, $manipulator->getSourceCode());
 

src/Security/UserClassBuilder.php

@@ -26,11 +26,11 @@
  */
 final class UserClassBuilder
 {
-    public function addUserInterfaceImplementation(ClassSourceManipulator $manipulator, UserClassConfiguration $userClassConfig): void
+    public function addUserInterfaceImplementation(ClassSourceManipulator $manipulator, UserClassConfiguration $userClassConfig, string $className): void
     {
         $manipulator->addInterface(UserInterface::class);
 
-        $this->addUniqueConstraint($manipulator, $userClassConfig);
+        $this->addUniqueConstraint($manipulator, $userClassConfig, $className);
 
         $this->addGetUsername($manipulator, $userClassConfig);
 
@@ -332,7 +332,7 @@ private function addSerialize(ClassSourceManipulator $manipulator): void
         $manipulator->addMethodBuilder($builder);
     }
 
-    private function addUniqueConstraint(ClassSourceManipulator $manipulator, UserClassConfiguration $userClassConfig): void
+    private function addUniqueConstraint(ClassSourceManipulator $manipulator, UserClassConfiguration $userClassConfig, string $className): void
     {
         if (!$userClassConfig->isEntity()) {
             return;
@@ -341,7 +341,7 @@ private function addUniqueConstraint(ClassSourceManipulator $manipulator, UserCl
         $manipulator->addAttributeToClass(
             'ORM\\UniqueConstraint',
             [
-                'name' => 'UNIQ_IDENTIFIER_'.strtoupper(Str::asSnakeCase($userClassConfig->getIdentityPropertyName())),
+                'name' => strtoupper(Str::asSnakeCase($className)).'_UNIQ_IDENTIFIER_'.strtoupper(Str::asSnakeCase($userClassConfig->getIdentityPropertyName())),
                 'fields' => [$userClassConfig->getIdentityPropertyName()],
             ]
         );

tests/Security/UserClassBuilderTest.php

@@ -23,12 +23,12 @@ class UserClassBuilderTest extends TestCase
     /**
      * @dataProvider getUserInterfaceTests
      */
-    public function testAddUserInterfaceImplementation(UserClassConfiguration $userClassConfig, string $expectedFilename): void
+    public function testAddUserInterfaceImplementation(UserClassConfiguration $userClassConfig, string $expectedFilename, string $className): void
     {
         $manipulator = $this->getClassSourceManipulator($userClassConfig);
 
         $classBuilder = new UserClassBuilder();
-        $classBuilder->addUserInterfaceImplementation($manipulator, $userClassConfig);
+        $classBuilder->addUserInterfaceImplementation($manipulator, $userClassConfig, $className);
 
         $expectedPath = $this->getExpectedPath($expectedFilename, null);
         $expectedSource = file_get_contents($expectedPath);
@@ -49,36 +49,43 @@ public function getUserInterfaceTests(): \Generator
         yield 'entity_with_email_as_identifier' => [
             new UserClassConfiguration(true, 'email', true),
             'UserEntityWithEmailAsIdentifier.php',
+            'User',
         ];
 
         yield 'entity_with_password' => [
             new UserClassConfiguration(true, 'userIdentifier', true),
             'UserEntityWithPassword.php',
+            'User',
         ];
 
         yield 'entity_with_user_identifier_as_identifier' => [
             new UserClassConfiguration(true, 'user_identifier', true),
             'UserEntityWithUser_IdentifierAsIdentifier.php',
+            'User',
         ];
 
         yield 'entity_without_password' => [
             new UserClassConfiguration(true, 'userIdentifier', false),
             'UserEntityWithoutPassword.php',
+            'User',
         ];
 
         yield 'model_with_email_as_identifier' => [
             new UserClassConfiguration(false, 'email', true),
             'UserModelWithEmailAsIdentifier.php',
+            'User',
         ];
 
         yield 'model_with_password' => [
             new UserClassConfiguration(false, 'userIdentifier', true),
             'UserModelWithPassword.php',
+            'User',
         ];
 
         yield 'model_without_password' => [
             new UserClassConfiguration(false, 'userIdentifier', false),
             'UserModelWithoutPassword.php',
+            'User',
         ];
     }
 

tests/Security/fixtures/expected/UserEntityWithEmailAsIdentifier.php

@@ -7,7 +7,7 @@
 use Symfony\Component\Security\Core\User\UserInterface;
 
 #[ORM\Entity]
-#[ORM\UniqueConstraint(name: 'UNIQ_IDENTIFIER_EMAIL', fields: ['email'])]
+#[ORM\UniqueConstraint(name: 'USER_UNIQ_IDENTIFIER_EMAIL', fields: ['email'])]
 class User implements UserInterface, PasswordAuthenticatedUserInterface
 {
     #[ORM\Id]

tests/Security/fixtures/expected/UserEntityWithPassword.php

@@ -7,7 +7,7 @@
 use Symfony\Component\Security\Core\User\UserInterface;
 
 #[ORM\Entity]
-#[ORM\UniqueConstraint(name: 'UNIQ_IDENTIFIER_USER_IDENTIFIER', fields: ['userIdentifier'])]
+#[ORM\UniqueConstraint(name: 'USER_UNIQ_IDENTIFIER_USER_IDENTIFIER', fields: ['userIdentifier'])]
 class User implements UserInterface, PasswordAuthenticatedUserInterface
 {
     #[ORM\Id]

tests/Security/fixtures/expected/UserEntityWithUser_IdentifierAsIdentifier.php

@@ -7,7 +7,7 @@
 use Symfony\Component\Security\Core\User\UserInterface;
 
 #[ORM\Entity]
-#[ORM\UniqueConstraint(name: 'UNIQ_IDENTIFIER_USER_IDENTIFIER', fields: ['user_identifier'])]
+#[ORM\UniqueConstraint(name: 'USER_UNIQ_IDENTIFIER_USER_IDENTIFIER', fields: ['user_identifier'])]
 class User implements UserInterface, PasswordAuthenticatedUserInterface
 {
     #[ORM\Id]

tests/Security/fixtures/expected/UserEntityWithoutPassword.php

@@ -6,7 +6,7 @@
 use Symfony\Component\Security\Core\User\UserInterface;
 
 #[ORM\Entity]
-#[ORM\UniqueConstraint(name: 'UNIQ_IDENTIFIER_USER_IDENTIFIER', fields: ['userIdentifier'])]
+#[ORM\UniqueConstraint(name: 'USER_UNIQ_IDENTIFIER_USER_IDENTIFIER', fields: ['userIdentifier'])]
 class User implements UserInterface
 {
     #[ORM\Id]