-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NullHandler handle 'bubble' argument #399
Comments
PS: thinking more about this: what is the use of a null logger if not to be used as 'blackhole'? Maybe we could leave it as is, but make code more explicit about it never bubbling... |
Ok, there is already a comment in the code that explicitly calls it a 'Blackhole'. I need moar coffee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems that the code is sending
bubble
config to Null handlers, but the code does not handle that.This could be fixed eg. by making NullHandler child of AbstractHandler instead of Handler
See:
vs
The text was updated successfully, but these errors were encountered: