Skip to content

Commit

Permalink
Merge branch '5.4' into 6.4
Browse files Browse the repository at this point in the history
* 5.4:
  Work around parse_url() bug (bis)
  fix PHP 7.2 compatibility
  silence PHP warnings issued by Redis::connect()
  Bump Symfony version to 5.4.48
  Update VERSION for 5.4.47
  Update CHANGELOG for 5.4.47
  [Routing] Fix: lost priority when defining hosts in configuration
  fix dumping tests to skip with data providers
  • Loading branch information
nicolas-grekas committed Nov 13, 2024
2 parents e6377be + c6839a1 commit cebafe2
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion Legacy/SymfonyTestsListenerTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

use Doctrine\Common\Annotations\AnnotationRegistry;
use PHPUnit\Framework\AssertionFailedError;
use PHPUnit\Framework\DataProviderTestSuite;
use PHPUnit\Framework\RiskyTestError;
use PHPUnit\Framework\TestCase;
use PHPUnit\Framework\TestSuite;
Expand Down Expand Up @@ -193,7 +194,13 @@ public function startTestSuite($suite): void
public function addSkippedTest($test, \Exception $e, $time): void
{
if (0 < $this->state) {
$this->isSkipped[\get_class($test)][$test->getName()] = 1;
if ($test instanceof DataProviderTestSuite) {
foreach ($test->tests() as $testWithDataProvider) {
$this->isSkipped[\get_class($testWithDataProvider)][$testWithDataProvider->getName()] = 1;
}
} else {
$this->isSkipped[\get_class($test)][$test->getName()] = 1;
}
}
}

Expand Down

0 comments on commit cebafe2

Please sign in to comment.