Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getUserIdentifier() instead of getUsername() in SF5.3 and higher? #110

Open
rsvitak opened this issue Feb 14, 2023 · 1 comment
Open

getUserIdentifier() instead of getUsername() in SF5.3 and higher? #110

rsvitak opened this issue Feb 14, 2023 · 1 comment

Comments

@rsvitak
Copy link

rsvitak commented Feb 14, 2023

I am sorry, this is likely a question than an issue report. An answer will actually help me to understand things.

On several places like this,

$identifier = $sid->getClass().'-'.$sid->getUsername();

there is the getUsername call, but, if the UserInterface::getUsername is deprecated since SF5.3, is it going to be replaced by getUserIdentifier() in the security-acl bundle too?

@wouterj
Copy link
Member

wouterj commented Feb 14, 2023

Hi! As far as I'm concerned, the ACL component and bundle are treated as "maintained by the community".

The core team does their best to merge new PRs, keep the build green and release versions, but we don't actively maintain or change anything in these packages. So even more than on the main repository, there is no roadmap and there are no plans for the ACL packages.

That said, if you think it makes sense to rename the method, you're free to start a PR imho :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants