Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] Collect all deprecations with lint:twig command #20840

Open
fabpot opened this issue Mar 29, 2025 · 3 comments
Open

[TwigBridge] Collect all deprecations with lint:twig command #20840

fabpot opened this issue Mar 29, 2025 · 3 comments
Milestone

Comments

@fabpot
Copy link
Member

fabpot commented Mar 29, 2025

Q A
Feature PR symfony/symfony#60039
PR author(s) @Fan2Shrek
Merged in 7.3

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.3 branch in the symfony-docs repository.

Thank you! 😃

@fabpot fabpot added this to the 7.3 milestone Mar 29, 2025
@RisingSunLight42
Copy link

RisingSunLight42 commented Mar 30, 2025

Unsure if any addition to the doc could be made? It's already mentionned in linting twig templates. It was already implied in the docs that it was listing all deprecations, so maybe instead of changing the doc for 7.3, change the doc of previous versions to add a notice that it will list the first deprecation encountered only?

@javiereguiluz
Copy link
Member

I like your plan ... mention in 6.4 and 7.2 that only the first deprecation is shown. Then, in 7.3, remove that and add a versionadded directive mentioning that now all deprecations are shown.

The contribution only needs to do this change in 6.4 and we'll merge this change in the other branches.

@RisingSunLight42 would you be able to send a pull request with this change? Thanks!

@RisingSunLight42
Copy link

I like your plan ... mention in 6.4 and 7.2 that only the first deprecation is shown. Then, in 7.3, remove that and add a versionadded directive mentioning that now all deprecations are shown.

The contribution only needs to do this change in 6.4 and we'll merge this change in the other branches.

@RisingSunLight42 would you be able to send a pull request with this change? Thanks!

Yes I can! Just to be sure, I do a PR on 6.4 with the mention of only the first deprecation is shown, and then you will take care of the rest for the other versions? Sorry If I'm asking something that seems obvious, I just want to not mess up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants