Skip to content

DI extensions implementing the CompilerPassInterface will be processed automatically #5738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xabbuh opened this issue Sep 29, 2015 · 3 comments
Closed

DI extensions implementing the CompilerPassInterface will be processed automatically #5738

xabbuh opened this issue Sep 29, 2015 · 3 comments
Labels
actionable Clear and specific issues ready for anyone to take them. DependencyInjection good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Milestone
2.7

Comments

@xabbuh
Copy link
Member

xabbuh commented Sep 29, 2015

With the ExtensionCompilerPass from symfony/symfony#13761, container extensions implementing the CompilerPassInterface will be executed automatically during compilation of the container.
@xabbuh xabbuh added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. DependencyInjection labels Sep 29, 2015
@xabbuh xabbuh added this to the 2.7 milestone Sep 29, 2015
@xabbuh xabbuh changed the title Document the ExtensionCompilerPass interface Document the ExtensionCompilerPassInterface Sep 29, 2015
@stof
Copy link
Member

stof commented Sep 29, 2015

Your description is wrong. They don't implement a new interface (which does not exist). they implement the existing CompilerPassInterface (and we have a new ExtensionCompilerPass used in the component automatically and responsible for the new feature)

@xabbuh xabbuh changed the title Document the ExtensionCompilerPassInterface DI extensions implementing the CompilerPassInterface will be processed automatically Sep 29, 2015
@xabbuh
Copy link
Member Author

xabbuh commented Sep 29, 2015

Oh, good catch. Thanks @stof.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jan 15, 2016
@xabbuh
Copy link
Member Author

xabbuh commented Jan 15, 2016

see #5920 for the PR

@wouterj wouterj closed this as completed Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. DependencyInjection good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
2.7
Development

No branches or pull requests
3 participants
@stof @wouterj @xabbuh