Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines for using GitHub reactions #6346

Closed
javiereguiluz opened this issue Mar 11, 2016 · 6 comments
Closed

Guidelines for using GitHub reactions #6346

javiereguiluz opened this issue Mar 11, 2016 · 6 comments

Comments

@javiereguiluz
Copy link
Member

As you know, GitHub as added reactions to issues, comments and pull requests. Do you think we should decide some basic guidelines to use them?

If you agree, this would be my proposal:

  • Use only :+1: or :-1: to vote for things.
  • Use reactions only for Issues and PRs, not comments.
  • Stop using 👍 and 👎 in comments as a voting mechanism.

Thoughts? Thanks!

@xabbuh
Copy link
Member

xabbuh commented Mar 11, 2016

I'd say let's wait some time to see how people actually use reactions. I would rather not put something more in the contribution guidelines that is not really necessary and focus on important stuff instead.

@javiereguiluz
Copy link
Member Author

I wouldn't put this information in the contribution guide. And besides, few people read it 😞 The question was more about how we should use them. For example, in this PR (#6345) you voted in an empty comment and I used a reaction icon.

@xabbuh
Copy link
Member

xabbuh commented Mar 11, 2016

At least for our internal voting mechanism we would have to stick to comments until gh is able to determine core team votes from reactions.

@xabbuh
Copy link
Member

xabbuh commented Mar 11, 2016

But I agree that it would now better if people generally used reactions to support a thread instead of pushing notifications to everyone by commenting with +1.

@javiereguiluz
Copy link
Member Author

That's a good point! I've added an issue in the gh tool to see what do they decide.

@javiereguiluz
Copy link
Member Author

I'm closing it because at symfony-docs we don't have a problem with this at all. Few people vote on issues/PRs, so let's do nothing about this for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants