-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidelines for using GitHub reactions #6346
Comments
I'd say let's wait some time to see how people actually use reactions. I would rather not put something more in the contribution guidelines that is not really necessary and focus on important stuff instead. |
I wouldn't put this information in the contribution guide. And besides, few people read it 😞 The question was more about how we should use them. For example, in this PR (#6345) you voted in an empty comment and I used a reaction icon. |
At least for our internal voting mechanism we would have to stick to comments until |
But I agree that it would now better if people generally used reactions to support a thread instead of pushing notifications to everyone by commenting with +1. |
That's a good point! I've added an issue in the |
I'm closing it because at |
As you know, GitHub as added reactions to issues, comments and pull requests. Do you think we should decide some basic guidelines to use them?
If you agree, this would be my proposal:
:+1:
or:-1:
to vote for things.Thoughts? Thanks!
The text was updated successfully, but these errors were encountered: