minor #1258 [Doc] Fix preConnect/connect inversion in "disconnect()" doc examples (smnandre)

weaverryan · weaverryan · commit bbdfa3a95cae · 2023-12-12T11:45:17.000-05:00
This PR was merged into the 2.x branch. Discussion ---------- [Doc] Fix preConnect/connect inversion in "disconnect()" doc examples Following symfony/ux#1227 i found other similar cases of callback inversion in the documentation. Commits ------- 3f8218f5 Fix preConnect/connect inversion in "disconnect()" doc examples
diff --git a/doc/index.rst b/doc/index.rst
@@ -156,8 +156,8 @@ Stimulus controller:
 
         disconnect() {
             // You should always remove listeners when the controller is disconnected to avoid side-effects
-            this.element.removeEventListener('swup:pre-connect', this._onConnect);
-            this.element.removeEventListener('swup:connect', this._onPreConnect);
+            this.element.removeEventListener('swup:connect', this._onConnect);
+            this.element.removeEventListener('swup:pre-connect', this._onPreConnect);
         }
 
         _onPreConnect(event) {

Original file line number	Diff line number	Diff line change
`@@ -156,8 +156,8 @@ Stimulus controller:`
`156`	`156`
`157`	`157`	`disconnect() {`
`158`	`158`	`// You should always remove listeners when the controller is disconnected to avoid side-effects`
`159`		`- this.element.removeEventListener('swup:pre-connect', this._onConnect);`
`160`		`- this.element.removeEventListener('swup:connect', this._onPreConnect);`
	`159`	`+ this.element.removeEventListener('swup:connect', this._onConnect);`
	`160`	`+ this.element.removeEventListener('swup:pre-connect', this._onPreConnect);`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`_onPreConnect(event) {`