minor #1258 [Doc] Fix preConnect/connect inversion in "disconnect()" doc examples (smnandre)

weaverryan · weaverryan · commit d23b5d683618 · 2023-12-12T11:45:17.000-05:00
This PR was merged into the 2.x branch. Discussion ---------- [Doc] Fix preConnect/connect inversion in "disconnect()" doc examples Following symfony/ux#1227 i found other similar cases of callback inversion in the documentation. Commits ------- 3f8218f5 Fix preConnect/connect inversion in "disconnect()" doc examples
diff --git a/doc/index.rst b/doc/index.rst
@@ -101,8 +101,8 @@ Stimulus controller:
 
         disconnect() {
             // You should always remove listeners when the controller is disconnected to avoid side-effects
-            this.element.removeEventListener('typed:pre-connect', this._onConnect);
-            this.element.removeEventListener('typed:connect', this._onPreConnect);
+            this.element.removeEventListener('typed:connect', this._onConnect);
+            this.element.removeEventListener('typed:pre-connect', this._onPreConnect);
         }
 
         _onPreConnect(event) {

Original file line number	Diff line number	Diff line change
`@@ -101,8 +101,8 @@ Stimulus controller:`
`101`	`101`
`102`	`102`	`disconnect() {`
`103`	`103`	`// You should always remove listeners when the controller is disconnected to avoid side-effects`
`104`		`- this.element.removeEventListener('typed:pre-connect', this._onConnect);`
`105`		`- this.element.removeEventListener('typed:connect', this._onPreConnect);`
	`104`	`+ this.element.removeEventListener('typed:connect', this._onConnect);`
	`105`	`+ this.element.removeEventListener('typed:pre-connect', this._onPreConnect);`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`_onPreConnect(event) {`