Replaced call to AsLiveComponent::getMethod

Author: hepisec

src/LiveComponent/src/Attribute/AsLiveComponent.php

@@ -124,11 +124,4 @@ public static function liveListeners(object|string $component): array
 
         return $listeners;
     }
-
-    public static function getMethod(object|string $component): string
-    {
-        $attributes = (new \ReflectionClass($component))->getAttributes(self::class);
-
-        return $attributes[0]->newInstance()->serviceConfig()['method'] ?? 'post';
-    }
 }

src/LiveComponent/src/EventListener/LiveComponentSubscriber.php

@@ -164,7 +164,8 @@ public function onKernelController(ControllerEvent $event): void
             throw new NotFoundHttpException(sprintf('The action "%s" either doesn\'t exist or is not allowed in "%s". Make sure it exist and has the LiveAction attribute above it.', $action, $component::class));
         }
 
-        $requestMethod = AsLiveComponent::getMethod($component);
+        $componentName = $request->attributes->get('_component_name') ?? $request->attributes->get('_mounted_component')->getName();
+        $requestMethod = $this->container->get(ComponentFactory::class)->metadataFor($componentName)?->get('method') ?? 'post';
 
         /**
          * $requestMethod 'post' allows POST requests only

src/LiveComponent/src/Util/LiveControllerAttributesCreator.php

@@ -98,14 +98,9 @@ public function attributesForRendering(MountedComponent $mounted, ComponentMetad
             $mountedAttributes = $mountedAttributes->defaults(['data-live-id' => $id]);
         }
 
-<<<<<<< HEAD
-        $requestMethod = AsLiveComponent::getMethod($mounted->getComponent());
-
-        if (!isset($mountedAttributes->all()['data-live-request-method-value'])) {
-            $attributesCollection->setRequestMethod($requestMethod);
-            $mountedAttributes = $mountedAttributes->defaults(['data-live-request-method-value' => $requestMethod]);
-=======
         $liveMetadata = $this->metadataFactory->getMetadata($mounted->getName());
+        $requestMethod = $liveMetadata->getComponentMetadata()?->get('method') ?? 'post';
+        $attributesCollection->setRequestMethod($requestMethod);
 
         if ($liveMetadata->hasQueryStringBindings()) {
             $queryMapping = [];
@@ -116,7 +111,6 @@ public function attributesForRendering(MountedComponent $mounted, ComponentMetad
                 }
             }
             $attributesCollection->setQueryUrlMapping($queryMapping);
->>>>>>> upstream/2.x
         }
 
         if ($isChildComponent) {

src/LiveComponent/tests/Functional/Controller/BatchActionControllerTest.php

@@ -178,7 +178,13 @@ public function testRedirectWithAcceptHeader(): void
 
         $this->browser()
             ->throwExceptions()
-            ->get('/_components/with_actions', ['query' => ['props' => json_encode($dehydrated->getProps())]])
+            ->post('/_components/with_actions', [
+                'body' => [
+                    'data' => json_encode([
+                        'props' => $dehydrated->getProps()
+                    ]),
+                ],
+            ])
             ->assertSuccessful()
             ->interceptRedirects()
             ->use(function (Crawler $crawler, KernelBrowser $browser) {

src/LiveComponent/tests/Unit/Attribute/AsLiveComponentTest.php

@@ -145,16 +145,6 @@ public function testCanCheckIfMethodIsAllowed(): void
         $this->assertFalse(AsLiveComponent::isActionAllowed($component, 'method2'));
         $this->assertTrue(AsLiveComponent::isActionAllowed($component, 'aListenerActionMethod'));
     }
-
-    public function testMethodDefaultsToPost(): void
-    {
-        $this->assertEquals('post', AsLiveComponent::getMethod(DummyLiveComponent::class));
-    }
-
-    public function testGetMethod(): void
-    {
-        $this->assertEquals('get', AsLiveComponent::getMethod(GetMethodComponent::class));
-    }
 }
 
 #[AsLiveComponent]