[Translator] Move already generated constants from static var to class property

Otherwise the generated constants were persisted between tests, and lead to bad constants names generation.

Author: Kocal

src/Translator/.gitignore

@@ -3,3 +3,5 @@
 /composer.lock
 /phpunit.xml
 /.phpunit.result.cache
+
+/var

src/Translator/src/TranslationsDumper.php

@@ -34,6 +34,7 @@ class TranslationsDumper
 {
     private array $excludedDomains = [];
     private array $includedDomains = [];
+    private array $alreadyGeneratedConstants = [];
 
     public function __construct(
         private string $dumpDir,
@@ -184,16 +185,14 @@ private function getLocaleFallbacks(MessageCatalogueInterface ...$catalogues): a
 
     private function generateConstantName(string $translationId): string
     {
-        static $alreadyGenerated = [];
-
         $translationId = s($translationId)->ascii()->snake()->upper()->replaceMatches('/^(\d)/', '_$1')->toString();
         $prefix = 0;
         do {
             $constantName = $translationId.($prefix > 0 ? '_'.$prefix : '');
             ++$prefix;
-        } while ($alreadyGenerated[$constantName] ?? false);
+        } while ($this->alreadyGeneratedConstants[$constantName] ?? false);
 
-        $alreadyGenerated[$constantName] = true;
+        $this->alreadyGeneratedConstants[$constantName] = true;
 
         return $constantName;
     }

src/Translator/tests/CacheWarmer/TranslationsCacheWarmerTest.php

@@ -28,7 +28,7 @@ public static function setUpBeforeClass(): void
 
     public static function tearDownAfterClass(): void
     {
-        @unlink(self::$cacheDir);
+        @rmdir(self::$cacheDir);
     }
 
     public function test()