Skip to content

[UX Map] Rename a variable #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz opened this issue Aug 30, 2024 · 1 comment · Fixed by #2113
Closed

[UX Map] Rename a variable #2111

javiereguiluz opened this issue Aug 30, 2024 · 1 comment · Fixed by #2113

Comments

@javiereguiluz
Copy link
Member

When using UX Map and Leaflet bridge to customize a marker, you have to do this:

const { definition, leaflet } = event.detail;
// ...

As suggested by @Kocal, the leaflet variable should probably be named L because Leaflet uses L in all its docs. Now that the bridge is so new (and experimental), we could even rename the variable wihout considering BC, etc.

Thanks

@Kocal
Copy link
Member

Kocal commented Aug 30, 2024

I can work on it tomorrow at noon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants