Skip to content

Commit eedc8ca

Browse files
committed
bug #406 Fix the mini-css-extract-plugin 0.4.3 issue and increase min. allowed Webpack version (Lyrkan)
This PR was merged into the master branch. Discussion ---------- Fix the mini-css-extract-plugin 0.4.3 issue and increase min. allowed Webpack version This PR fixes both of the issues detected in #403: - Set the maximum allowed version for `mini-css-extract-plugin` to 0.4.2 (since 0.4.3 doesn't work with the current version of the webpack-manifest-plugin, see #404). This is a temporary solution, once it's fixed (either in mini-css-extract-plugin or in weback-manifest-plugin) we'll have to change it again. - Set the minimum allowed version for `webpack` to 4.20.0. The previous one (4.0.0) seemed to break `mini-css-extract-plugin` (see https://travis-ci.org/Lyrkan/webpack-encore/jobs/439810002). Commits ------- 04f42af Temporary fix for the mini-css-extract-plugin 0.4.3 issue
2 parents 831adff + 04f42af commit eedc8ca

File tree

2 files changed

+194
-202
lines changed

2 files changed

+194
-202
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@
3838
"fs-extra": "^2.0.0",
3939
"loader-utils": "^1.1.0",
4040
"lodash": ">=3.5 <5",
41-
"mini-css-extract-plugin": "^0.4.0",
41+
"mini-css-extract-plugin": ">=0.4.0 <0.4.3",
4242
"pkg-up": "^1.0.0",
4343
"pretty-error": "^2.1.1",
4444
"resolve-url-loader": "^2.3.0",
4545
"semver": "^5.5.0",
4646
"style-loader": "^0.21.0",
4747
"tmp": "^0.0.33",
4848
"uglifyjs-webpack-plugin": "^1.2.5",
49-
"webpack": "^4.0.0",
49+
"webpack": "^4.20.0",
5050
"webpack-chunk-hash": "^0.6.0",
5151
"webpack-cli": "^3.0.0",
5252
"webpack-dev-server": "^3.1.4",

0 commit comments

Comments
 (0)