Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] UriSigner to become internal in 2.x #165

Merged
merged 2 commits into from
Mar 14, 2024
Merged

[1.x] UriSigner to become internal in 2.x #165

merged 2 commits into from
Mar 14, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Mar 12, 2024 •
edited
Loading

  • Adds internal & final docBlock to UriSignerFactory
  • Refactor class to use constructor property promotion
  • Adds SensitiveParameter attribute to $secret property. (Prevents stack trace leaks in PHP >=8.2)
  • Init UPGRADE.md guide for BC changes coming in v2.0

The UriSignerFactory will no longer be needed in v2.0. The intent is to make this internal in v2.0.0 then remove it in a later v2.x release. This should avoid having to deprecate it in v2.0 then remove it in v3.0 - while preserve BC for v1.x.

Precursor to #164

@jrushlow jrushlow added Status: Needs Review Needs to be reviewed Feature New Feature labels Mar 12, 2024
@jrushlow jrushlow mentioned this pull request Mar 12, 2024
Merged
bocharsky-bw
bocharsky-bw approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

@jrushlow jrushlow merged commit e44ebca into SymfonyCasts:main Mar 14, 2024
8 checks passed
@jrushlow jrushlow deleted the feature/1.x/deprecate-factor branch March 14, 2024 08:11
@jrushlow jrushlow mentioned this pull request Mar 16, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
Feature New Feature Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrushlow @bocharsky-bw