Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scenario default action #803

Closed
bruncsak opened this issue Nov 18, 2019 · 4 comments · Fixed by #804
Closed

scenario default action #803

bruncsak opened this issue Nov 18, 2019 · 4 comments · Fixed by #804
Labels
bug ready A PR is waiting to be merged. Close to be solved
Milestone

Comments

@bruncsak
Copy link

bruncsak commented Nov 18, 2019

What is the default action when no condition match in a scenario?

At this moment the default/scenari/create_list.listmaster contains:

title.gettext restricted to listmaster

is_listmaster([sender]) md5,smime -> do_it
true() smtp,md5,smime -> reject(reason='create_list_listmaster')

Supposedly the true() condition does not match when I am arriving with dkim authentication method. What action will happen, and what action supposed to happen?

@racke racke added the question label Nov 18, 2019
@ikedas
Copy link
Member

ikedas commented Nov 19, 2019

Looks similar to #775 .

@bruncsak
Copy link
Author

Dear @ikedas,

Just for the shake of completeness. The command:
cat default/scenari/*|awk '$1 !~ /^(title\.gettext|#)?$/ {print $(NF-2)}'|sort|uniq -c
gives:
19 dkim,md5,smime
49 md5,smime
12 smime
16 smime,md5
19 smtp
24 smtp,dkim
2 smtp,dkim,md5
163 smtp,dkim,md5,smime
44 smtp,dkim,smime,md5
4 smtp,md5,smime

Out of that the last (with 4 occurences) is the interesting, they are in:

default/scenari/create_list.intranet
default/scenari/create_list.listmaster
default/scenari/create_list.public_listmaster
default/scenari/del.owner

@ikedas
Copy link
Member

ikedas commented Nov 20, 2019

I tried with 6.2.48:

$ cat default/scenari/* | sed -ne 's/.*[ \t]\([^ \t][^ \t]*\)[ \t]*->.*/\1/p' | sort | uniq -c
     19 dkim,md5,smime
     49 md5,smime
     12 smime
     16 smime,md5
     20 smtp
     23 smtp,dkim
      2 smtp,dkim,md5
    152 smtp,dkim,md5,smime
     43 smtp,dkim,smime,md5
     20 smtp,md5,smime
      1 smtp,smime,md5

and also found a few:

smtp:

  • default/scenari/send.ownerauth (-)

smtp,md5,smime:

  • default/scenari/create_list.intranet (*)
  • default/scenari/create_list.listmaster (*)
  • default/scenari/create_list.public_listmaster (*)
  • default/scenari/del.owner (*)
  • default/scenari/info.conceal (-)
  • default/scenari/info.open (-)
  • default/scenari/info.private (-)
  • default/scenari/send.owner (-)
  • default/scenari/send.ownerauth (-)
  • default/scenari/subscribe.intranetorowner
  • default/scenari/visibility.intranet

smtp,smime,md5:

  • default/scenari/send.owner (-)

(-): Fixed by #775 .
(*) Pointed out by @bruncsak.

@ikedas ikedas added bug ready A PR is waiting to be merged. Close to be solved and removed question labels Nov 20, 2019
@ikedas ikedas added this to the 6.2.50 milestone Nov 20, 2019
@ikedas
Copy link
Member

ikedas commented Nov 22, 2019

Fixed. Thanks for reporting bugs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready A PR is waiting to be merged. Close to be solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants