Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password is not strong enough. #208

Open
designermonkey opened this issue Feb 7, 2013 · 13 comments
Open

Password is not strong enough. #208

designermonkey opened this issue Feb 7, 2013 · 13 comments

Comments

@designermonkey
Copy link
Member

When entering a password which is set to 'strong', this message comes up.

Not really helpful as it doesn't explain the complexity required.

Also, what is the complexity required for each level?

@michael-e
Copy link
Member

I think that this has been thought of and discussed when Members was programmed. Any further eplanation of the error wouldn't work with translations, that's for sure. Symphony uses generic error messages in many places, and it is always up to the developer to catch them and output useful information in the templating layer.

Also, what is the complexity required for each level?

See the wiki

@designermonkey
Copy link
Member Author

Ok, this was from the backend though. I really do think this is weird.

@michael-e
Copy link
Member

Why the hell would you create a Member from the backend?

@designermonkey
Copy link
Member Author

To test it all works lol.

Plus we have a client who has a predefined set of trade accounts, that are stored in the same section as retail accounts. Trade will be entered in the backend by our client, and provided a password chosen for them, retail from the frontend.

@michael-e
Copy link
Member

I see. But for a well-trained author in the backend, should this message not suffice? :-)

@designermonkey
Copy link
Member Author

Possibly, but we all know clients in reality.

I do think a p.help needs adding to the top of the field to explain the strength requirements. I don't see how this could cause a translation problem.

That way the error would have a context as reference.

@michael-e
Copy link
Member

That was just from memory, so I may be proven wrong here. Translators like @nilshoerrmann will know better.

Anyway that would be monster string, probably too long for a p.help sitting on top of the field.

If you want to suggest some strings, don't forget the "password too short" message.

@brendo
Copy link
Member

brendo commented Feb 8, 2013

Could Documenter help?

@nilshoerrmann
Copy link
Contributor

What kind of problems do you expect for translators, Michael?
If it's a string, it's translatable. Or do you think it's too complex for translators to understand :D

@michael-e
Copy link
Member

Maybe I don't remember correctly. We should take a look at all the possible error strings.

@designermonkey
Copy link
Member Author

I'm going to come back to this. It may be beneficial to allow each level to be defined by the developer. I am not happy with any of the levels, as they don't suit our password policies at all.

@michael-e
Copy link
Member

michael-e commented Oct 20, 2017

Does anybody still have issues with this? Otherwise, we should consider this thread outdated and close it.

@nitriques
Copy link
Member

Well, I think this can still be improved. The message does not helps the user. I would keep open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants