-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge case: Update Email #226
Comments
What about the username field? Does that have the same logging out behaviour too? If so then it should be resolved with a |
Didn't test with the Simpler solution would be to get rid of the Question is, should we simplify the |
I'm all up for simplification, had some troubles understanding how it all works myself so far, to the point of leaving loads ou for a later date. |
Third option would be, make how the filters work (password optional, re-login) the default behavior behind the scenes when updating an entry. This would make the extension easier to understand for developers and we wouldn't lose existing functionality. Let's see what @brendo has to say about this. |
I have a form which allows logged-in members to change their account data.
The corresponding event has the
Members: Update Password
-filter attached, so members can change data like name (defaultInput
-field) etc.They also can change their email-address (
Member: Email
-field), which I use as the primary identifier.After saving the entry (with the new email-address), the member is automatically logged out, which is confusing.
If a member changes their password, the
Members: Update Password
-filter will log them back in automatically. This does also work when emai-address AND password are both changed or re-entered, but not if only the email-address was changed and the password-field was left empty.I guess I can implement an additional
Members: Update Email
- orMembers: Update Username
-filter myself, but wanted to hear some feedback on this edge case before getting my hands dirty.The text was updated successfully, but these errors were encountered: