[Synfig Studio] Fixed incorrect import of lst files when path contains non-Latin characters
#1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ins non-Latin characters
rodolforg
reviewed
Dec 13, 2020
Comment on lines
+72
to
+73
| // TODO(ice0): There is no way to report about error to GUI. We can't | ||
| // throw error from constructor (bad practice), and can't return error code. |
There was a problem hiding this comment.
Agree. Should we refactor the Importer class to have a load() method – that should be called only once?
There was a problem hiding this comment.
I think yes, this is a good idea. We can back to this problem after 1.4.1 release.
rodolforg
reviewed
Dec 13, 2020
No problem here, I already tested it and all works fine. Just need someone who can check the code too. |
ice0
added a commit
to ice0/synfig
that referenced
this pull request
Dec 30, 2020
…ins non-Latin characters (synfig#1924) (cherry picked from commit 7d68380)
Merged
ice0
added a commit
to ice0/synfig
that referenced
this pull request
Feb 28, 2021
…ins non-Latin characters (synfig#1924) (cherry picked from commit 7d68380)
morevnaproject
pushed a commit
to morevnaproject/synfig
that referenced
this pull request
Aug 9, 2021
…ins non-Latin characters (synfig#1924) (cherry picked from commit 7d68380)
morevnaproject
pushed a commit
to morevnaproject/synfig
that referenced
this pull request
Aug 9, 2021
…ins non-Latin characters (synfig#1924) (cherry picked from commit 7d68380)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1898